[英]Can't save related objects in django models using pre_save signal
I have to implement multi-aspect type of inheritance from UML in Django ORM. 我必须在Django ORM中从UML实现多方面类型的继承 。 I have Contract
data type which depending on type of customer (regular or business customer) can be classified as RegularContract
or BusinessContract
. 我有Contract
数据类型,根据客户类型(常规或商业客户)可以分类为RegularContract
或BusinessContract
。 Also contract can have expiration date or be non-expirable (it is not specified how long it will be valid), so it also can be of type ExpiringContract
or NonExpiringContract
. 合同也可以有到期日期或不可过期(未指定有效期多长),因此它也可以是ExpiringContract
或NonExpiringContract
类型。 This is how concept diagram looks: 这是概念图的外观:
And this is how I've implemented this: 这就是我实现这个的方式:
models.py code: models.py代码:
class Contract(models.Model):
approval_date = models.DateTimeField(null=False)
def __getattr__(self, item):
if self.expiringcontract:
return getattr(self.expiringcontract, item)
elif self.nonexpiringcontract:
return getattr(self.nonexpiringcontract, item)
class ContractExpirationExtension(models.Model):
base = models.OneToOneField("website.Contract",
on_delete=models.CASCADE)
class Meta:
abstract = True
class ExpiringContract(ContractExpirationExtension):
termination_date = models.DateTimeField()
@property
def duration(self):
return self.termination_date - self.base.approval_date
class NonExpiringContract(ContractExpirationExtension):
@property
def duration(self):
return timedelta(days=100)
class ContractTypeExtension(models.Model):
base = models.OneToOneField("website.Contract", on_delete=models.CASCADE)
termination_delay = models.PositiveSmallIntegerField(default=30)
class Meta:
abstract = True
@classmethod
def create(cls, approval_date, contract_expiration_type, termination_delay, **kwargs):
type_extension = cls(termination_delay=termination_delay)
base = Contract(approval_date=approval_date)
expiration_type = contract_expiration_type(**kwargs)
expiration_type.base = base
type_extension.base = base
if contract_expiration_type.__name__ == ExpiringContract.__name__:
type_extension.base.expiringcontract = expiration_type
elif contract_expiration_type.__name__ == NonExpiringContract.__name__:
type_extension.base.nonexpiringcontract = expiration_type
return type_extension
def __getattr__(self, item):
if self.base:
return getattr(self.base,item)
class RegularContract(ContractTypeExtension):
termination_delay = models.PositiveSmallIntegerField(validators=[validate_term_delay_regular], blank=False)
class BusinessContract(ContractTypeExtension):
termination_delay = models.PositiveSmallIntegerField(validators=[validate_term_delay_business], blank=False)
When we need to create new contract model instance we use create()
method from classes that inherit ContractTypeExtension
abstract class. 当我们需要创建新的契约模型实例时,我们使用继承ContractTypeExtension
抽象类的类中的create()
方法。 In create()
method I create Contract
base instance and appropriate expiring or non expiring instance of contract based on class object argument i pass to create()
method: 在create()
方法中,我创建了Contract
基础实例和基于类对象参数的合适的到期或非到期合同实例,我传递给create()
方法:
@classmethod
def create(cls, approval_date, contract_expiration_type, termination_delay, **kwargs):
type_extension = cls(termination_delay=termination_delay)
base = Contract(approval_date=approval_date)
expiration_type = contract_expiration_type(**kwargs)
expiration_type.base = base
type_extension.base = base
if contract_expiration_type.__name__ == ExpiringContract.__name__:
type_extension.base.expiringcontract = expiration_type
elif contract_expiration_type.__name__ == NonExpiringContract.__name__:
type_extension.base.nonexpiringcontract = expiration_type
return type_extension
Because my instance of regular or business contract contains other model instances in it I can't save it without saving base
and expiration_type
instance first, so I decided to create pre_save
signal which will do exactly that: 因为我的常规或业务合同实例中包含其他模型实例,所以我不能保存它而不先保存base
和expiration_type
实例,所以我决定创建pre_save
信号,它将完全执行:
signals.py : signals.py :
from django.db.models.signals import pre_save, pre_delete from django.dispatch import receiver
from .models import RegularContract, BusinessContract
@receiver(pre_save, sender=RegularContract)
@receiver(pre_save, sender=BusinessContract)
def pre_save_contract(sender, instance, *args,**kwargs):
print("Pre_save")
if not instance.id:
instance.base.save()
try:
instance.base.expiringcontract.save()
except (TypeError, ValueError):
instance.base.nonexpiringcontract.save()
I registered my signal file in __init__
of app and in apps.py
config: 我在app的__init__
和apps.py
配置中注册了我的信号文件:
apps.py : apps.py :
from django.apps import AppConfig
class WebsiteConfig(AppConfig):
name = 'website'
def ready(self):
import website.signals
website.__init__.py : website.__init__.py :
default_app_config = 'website.apps.WebsiteConfig'
To test my code I've written simple test cases: 为了测试我的代码,我编写了简单的测试用例:
class BusinessContractTestCase(TestCase):
def setUp(self):
pass
def test_exprirating_creation(self):
approval_date = datetime.today()
termination_delay = 30
termination_date = approval_date+timedelta(days=720)
contract = BusinessContract.create(approval_date=approval_date, contract_expiration_type=ExpiringContract,
termination_delay=termination_delay,
termination_date=termination_date)
contract.save()
self.assertEqual(contract.termination_date.date(), ExpiringContract.objects.first().termination_date.date())
class RegularContractTestCase(TestCase):
def test_exprirating_creation(self):
approval_date = datetime.today()
termination_delay = 30
termination_date = approval_date + timedelta(days=720)
contract = RegularContract.create(approval_date=approval_date,
contract_expiration_type=ExpiringContract,
termination_delay=termination_delay,
termination_date=termination_date)
contract.save()
self.assertEqual(contract.termination_date.date(),
ExpiringContract.objects.first().termination_date.date())
But when trying to run this tests they fail and I get this error: 但是当尝试运行此测试时,它们会失败并且我收到此错误:
Error
Traceback (most recent call last):
File "/home/ubuntu/workspace/webapp/website/tests.py", line 21, in test_exprirating_creation
contract.save()
File "/home/ubuntu/workspace/venv/lib/python3.5/site-packages/django/db/models/base.py", line 685, in save
"unsaved related object '%s'." % field.name
ValueError: save() prohibited to prevent data loss due to unsaved related object 'base'.
So why pre_save
signal is not triggered in my code? 那么为什么我的代码中没有触发pre_save
信号呢?
After short debugging, I've understood my problem (thanks to Willem Van Onsem for pointing out that detail with pre_save
.) This is how I solved it. 经过简短的调试,我已经理解了我的问题(感谢Willem Van Onsem用pre_save
指出了这个细节。)这就是我解决它的方法。 I slightly modified create()
method. 我略微修改了create()
方法。 Instead of assigning base
to directly to newly created instance and expiration_type
to base I save those to temporary variables which I can later use in my signal method: 不是将base
直接分配给新创建的实例,而是将expiration_type
分配给base
,而是将它们保存到临时变量中,以后我可以在我的signal方法中使用它们:
@classmethod
def create(cls, approval_date, contract_expiration_type, termination_delay, **kwargs):
type_extension = cls(termination_delay=termination_delay)
base = Contract(approval_date=approval_date)
expiration_type = contract_expiration_type(**kwargs)
type_extension.temp_base = base
if contract_expiration_type.__name__ == ExpiringContract.__name__:
type_extension.temp_expiringcontract = expiration_type
elif contract_expiration_type.__name__ == NonExpiringContract.__name__:
type_extension.base.temp_nonexpiringcontract = expiration_type
return type_extension
Then in signals.py
in pre_save
signal I separately save base from temporary variable and assign to instance's base and separately assign my expiring/nonexpiring contract type instance from temporary variable to base and save it: 然后在signals.py
在pre_save
信号我单独保存的临时变量的基础,并分配给实例的基地,并分别指派我的到期/从临时变量nonexpiring合同类型的实例立足并保存:
@receiver(pre_save, sender=RegularContract)
@receiver(pre_save, sender=BusinessContract)
def pre_save_contract(sender, instance, *args, **kwargs):
print("Pre_save")
instance.temp_base.save()
instance.base = instance.temp_base
if hasattr(instance,"temp_expiringcontract"):
instance.base.expiringcontract = instance.temp_expiringcontract
instance.base.expiringcontract.save()
else:
instance.base.nonexpiringcontract = instance.temp_nonexpiringcontract
instance.base.nonexpiringcontract.save()
This is probably not the best solution, but at least it works. 这可能不是最好的解决方案,但至少它可行。
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.