C＃saveFileDialog打开两次

Question

I have a datatable (dt) and a button to export the data to excel.

I'm using ClosedXML to do the job done.

But, when I click on export button, I got first saveFileDialog and then after I click OK, I got a second saveFileDialog. After this, the file is exported correctly.

So, the code...

This is the main code for the button export action. I'm using the saveFileDIalog to allow user choose the save file directory.

private void exportarToolStripMenuItem_Click(object sender, EventArgs e)
    {
        if(saveFileDialog.ShowDialog() == DialogResult.OK)
        {
            FileInfo fileInfo = new FileInfo(saveFileDialog.FileName);
            SaveToExcel(dt, fileInfo);
        }
    }

Then, the methods

public static void SaveToExcel(System.Data.DataTable dt, FileInfo outputFile)
    {
        XLWorkbook wb = new XLWorkbook();
        var worksheet = wb.Worksheets.Add(dt, "ResultTable");

        using (MemoryStream memoryStream = GetStream(wb))
        {
            File.WriteAllBytes(outputFile.FullName, memoryStream.ToArray());
        }
    }

And the MemoryStream

public static MemoryStream GetStream(XLWorkbook excelWorkbook)
    {
        using (MemoryStream stream = new MemoryStream())
        {
            excelWorkbook.SaveAs(stream, new SaveOptions { EvaluateFormulasBeforeSaving = false, GenerateCalculationChain = false, ValidatePackage = false,  });
            return stream;
        }
    }

Can please someone help me see why I'm getting 2 saveFileDialog?

Thanks.

Answer 1

I see a problem; I added some comments:

private void exportarToolStripMenuItem_Click(object sender, EventArgs e)
{
    string filename = saveFileDialog.FileName; // what is this for? I would remove it.
    if(saveFileDialog.ShowDialog() == DialogResult.OK)
    {
        // problem in the following line, explained below
        string path = Path.GetFullPath(filename);
        // you should be picking the saveFileDialog.FileName at this point  to get
        // the user selection, not the filename variable you got before;
        // moreover, the saveFileDialog.FileName is already a full path, no need to
        // call the Path.GetFullPath method
        FileInfo fileInfo = new FileInfo(path);
        SaveToExcel(dt, fileInfo);
    }
}

Edit: And other problems are reported in other users' comments (bad MemoryStream management)