尝试使用Javascript onClick使动态PHP链接转到另一个页面

Question

I have a drop down menu that populates dynamically using a php function. the return string is as follows:

    $return_string .= "<li class='dropdown-item-row row' style='" . $style . "' onClick='window.location.href='" . $row['link'] . "'>
                        <span class='dd-pic'>
                            <img src='" . $user_data['profile_pic'] . "'>
                        </span>
                        <span class='dd-right'>
                            <span class='dd-date'>
                                        " . $time_message . "
                            </span>
                            <span class='dd-notif-text'>" . $row['message'] . "</span>
                        </span>
                      </li>"; 

When the user clicks on the link it will take them to the specific notification. I have on the <li> tag onClick='window.location.href='" . $row['link'] . "' The error I'm getting here is Uncaught SyntaxError: Unexpected end of input. Can anyone see something that I'm missing here?

It works locally if I wrap it in an <a> tag, but this is silly given it's around an <li> tag and will likely not work on remote server. I thought something simple in JS like this might be the solution.

Any help appreciated! Thanks is advance.

Answer 1

Inside double quotes "$var" simple variables don't need to be concatenated. This should work:

$return_string .= "<li class='dropdown-item-row row' 
 style='$style' 
 onClick=\"javascript:window.location.href='" . $row['link'] . "';\">

 <span class='dd-pic'>
 <img src='" . $user_data['profile_pic'] . "'>
 </span>
 <span class='dd-right'>
  <span class='dd-date'>$time_message</span>
  <span class='dd-notif-text'>" . $row['message'] . "</span>
 </span>
</li>";