如何根据单元格值删除文件？

Question

I'm having trouble deleting a file based on cell value. I get an error message on the line with the Kill command below:

Kill path & r.Offset(1, -4) & "\" & r.Offset(1, -3)

Any ideas?

Sub INACTIVE_files()

    Const path = "C:\Users\NikolouzosD\AppData\Local\Temp\vbakillfunction\"

    Dim r As Range
    Dim x As Integer

    Set r = Cells(1, 5)
    Do Until r = ""
        If UCase(r.value) = "INACTIVE" Then

            Kill path & r.Offset(1, -4) & "\" & r.Offset(1, -3)
          End If
          Set r = r.Offset(1, 0)
    Loop

End Sub

The code starts from cell E1 and looks for INACTIVE files in the same column, until there's no more files to look for. Then, it checks the folder name (Column A), combines it with the Cube (Column B) and puts both of them in a path:

path = "C:\Users\NikolouzosD\AppData\Local\Temp\vbakillfunction\"

so for example: for cell E2 which is INACTIVE, the path should be:

C:\Users\NikolouzosD\AppData\Local\Temp\vbakillfunction\WPO 17 02 04 3MMT All Periods\BG023104.txt

It then deletes the INACTIVE files (Cubes) from the appropriate folder.

Answer 1

Wrap your path in double quotes to avoid issues with spaces in filenames and folders.

Even better is to put the path in a string variable so you can debug it easily

Outside your loop:

Dim strPath As String

Inside your if block:

   strPath = """" & path & r.Offset(1,-4) & "\" & r.Offset(1,-3) & """"
   Debug.Print strPath ' Ctrl-G to view results
   Kill strPath

EDIT - add a check for file before deleting

Under Tools | References Tools | References

Add a reference to Windows Script Hosting

Then at top of sub code add

Dim fso as New FileSystemObject

Replace your Kill command with a check for existence

If fso.FileExists(strPath) Then
   Kill strPath
Else
   Msgbox "File Doesn't Exist: " & strPath
End If

UPDATED FOR CONTINUE TO NEXT FILE

Change loop to be:

Do Until r = ""
   If UCase(r.value) = "INACTIVE" AND fso.FileExists(strPath) Then
        Kill strPath
   End If
   Set r = r.Offset(1, 0)
Loop

Answer 2

It works! I've commented out some parts of the code that were used for checking if a file exists.

 Sub delete_INACTIVE_files()


Const path = "C:\Users\Dn\AppData\Local\Temp\vbakillfunction\"
Dim r As Range


Set r = Cells(1, 5)

Do Until r = ""


    If UCase(r.Value) = "INACTIVE" Then

        If Dir(path & r.Offset(0, -4) & "\" & r.Offset(0, -3) & ".txt") <> "" Then 'Does the file exist?

            'MsgBox "file" & path & r.Offset(0, -4) & "\" & r.Offset(0, -3) & ".txt" & " exists"

            Kill path & r.Offset(0, -4) & "\" & r.Offset(0, -3) & ".txt"


        'Else

            'MsgBox "file" & path & r.Offset(0, -4) & "\" & r.Offset(0, -3) & ".txt" & " not here"


        End If

    End If

    Set r = r.Offset(1, 0)

Loop

End Sub