对类中的不同变量运行相同的方法

Question

I have a class with about 10 or more different boolean values that record whether a user has done a particular action that will give them a specific reward (eg send a message to someone).

here is the code for one method for ONE bool/action:

private ReqRewardResult setMsgSent(RewardClass reward, RewardInfo info)
{
    if (reward.msgSent)
        return ReqRewardResult.RewardAlreadyGiven;

    reward.msgSent = true;
    reward.earned += info.msgSentReward;
    return ReqRewardResult.ReqSuccess;
}

I have tried to create a generic method for this but it seems you can't pass a class variable as a reference?

private ReqRewardResult setRewardAction(ref bool bAction, RewardClass reward, int reward)
{
    if (bAction)
        return ReqRewardResult.RewardAlreadyGiven;

    bAction = true;
    reward.earnedTokens += reward;
    return ReqRewardResult.ReqSuccess;
}

I have then looked at a couple of methods such as using a delegate function... but this is then kinda pointless as i'd have to repeat several lines again...

I have also seen you could use Reflection... but this is really slow and as this is a web app i'd rather use more repeated code if it improves the overall speed...

The question: Is there anyway to have a class function that can repeat for several variables of the same type without any performance hit?

NOTE: This class is data that is loaded from a database and is unique to each user (there could be millions of users)

Many Thanks,

Phil.

Answer 1

class RewardCredit
{
   public bool Rewarded { get; set; }

   public int Points { get; set; }
}

You could use a Dictionary<string, RewardCredit> , fill it with reward names as strings and have a function like

void ApplyReward(string rewardName)
{
    if (!rewards.ContainsKey(rewardName))
    {
        return;
    }

    RewardCredit credit = rewards[rewardName];
    if (!credit.Rewarded)
    {
        tokens += credit.Points;
        credit.Rewarded = true;
    }
}

You'd then end up using it like so

Dictionary<string, RewardCredit> rewards = new Dictionary<string, RewardCredit>
{
    { "Message", new RewardCredit { Points = 10 } },

};

ApplyReward("Message");

Answer 2

First it looks like you have a finish and known set of possible user actions that can be rewarded with "tokens" if done by a user. This can be implemented with the following class:

public sealed class UserAction
{
    public static UserAction SendMessage = new UserAction(3);
    public static UserAction PhonedFriend = new UserAction(4);
    public static UserAction LikedPost = new UserAction(1);
    public static UserAction CommentedOnPost = new UserAction(2);
    private UserAction(int tokens) => Tokens = tokens;
    public int Tokens { get; }
}

Notes:

• The constructor is made private and only the few instances of this class that must exist are available with predefined names and tokens
• The class is sealed to avoid being inherited, so that it effectively is impossible to create other instances than the one you provided

Then, so far I understand, each user may have done each action (or not) but must be rewarded no more than once for each. This make me think that you need to store a set of these UserAction s into a User . You also need a way to add an action to a user (when he effectively does in on the UI, for example) and also be able to know how much tokens each user has earned. The following class implements such behavior:

public sealed class User
{
    private readonly HashSet<UserAction> _doneActions;
    public User() => _doneActions = new HashSet<UserAction>();
    public ReqRewardResult AddAction(UserAction action) => _doneActions.Add(action) ? ReqRewardResult.ReqSuccess : ReqRewardResult.RewardAlreadyGiven;
    public int EarnedTokens => _doneActions.Sum(ua => ua.Tokens);
}

Note:

• I'm taking advantage of the HashSet.Add() 's return value to determine if the action had already been done in the past or not

Advantages of this "object-thinky" solution:

• No more booleans and if , which I believe makes your code more maintainable and clear
• Simplicity to add a new UserAction (one LoC)