如何计算空格，元音和字符的数量？

Question

import java.util.*;
import java.lang.String;
public class counter
{
    public static void main(String[] args)
    {
        Scanner in = new Scanner(System.in);
        int space = 0,vowel = 0,chara = 0,i;
        System.out.println(" Enter String ");
        String s =in.nextLine();
        for( i = 0; i < s.length(); i++)
        {
            char ch = in.next().charAt(i);
            if(ch == ' ')
                space++;
            if(ch == 'e' || ch == 'e' || ch == 'i' || ch == 'o' || ch == 'u')
                vowel++;
            else
                chara++;
            System.out.println("Number of Vowels = "+vowel);
            System.out.println("Number of Spaces = "+space);
            System.out.println("Number of Char   = "+chara);

        }
    }
}  

What is the problem? I have put three counters to count. I am coding in Eclipse and whenever I check the console I am not able to count the characters. It is just accepting inputs and not doing anything else.

Answer 1

Remove char ch = in.next().charAt(i); , and replace the other instances of ch with s.charAt(i)

The first charAt check should also be a , you have e twice.

Then move System.out.println... outside of the loop.

Online Demo

Answer 2

You should change s = in.next().charAt(i); to String s =in.nextLine() and put System.out.println part outside of for loop.

Also there is double 'e' (with the help of @Ted Hopp):

ch == 'e' || ch == 'e' ch == 'e' || ch == 'e' to ch == 'e' || ch == 'a' ch == 'e' || ch == 'a'

public static void main(String[] args)
{
    Scanner in = new Scanner(System.in);
    int space = 0,vowel = 0,chara = 0,i;
    System.out.println(" Enter String ");
    String s =in.nextLine();

    for( i = 0; i < s.length(); i++)
    {
        char ch = s.charAt(i);
        if(ch == ' ')
         space++;
        if(ch == 'e' || ch == 'e' || ch == 'i' || ch == 'o' || ch == 'u')
            vowel++;
        else
        chara++;


    }
    System.out.println("Number of Vowels = "+vowel);
    System.out.println("Number of Spaces = "+space);
    System.out.println("Number of Char   = "+chara);
}

Answer 3

Just a couple of typo errors. Change your code with,

String s = in.nextLine().toLowerCase();

And

char ch = s.charAt(i);

And

if(ch == 'a' || ch == 'e' || ch == 'i' || ch == 'o' || ch == 'u')

---

In your code you are using lowercase letters to compare with the user input. So you should convert the user input to lower case first. Your current code ignores all uppercase vowels(E, A, I ...). Use toLowerCase() .

By using in.next() the Scanner is waiting for an input. Since you have already taken an input using nextLine() you can use that.

Next one is obviously a typographical error. Vowels are A, E, I, O, U.