如何读取EXE字节，存储到char数组中，然后将字节写入新的EXE文件中？

Question

I am trying to read bytes from an EXE file, send the bytes via socket, and then write the bytes into another EXE file. The problem is that when I write the bytes to a EXE file and then try to open the EXE, Windows throws me an error:

Here is my code for reading the bytes from the original EXE file:

if (newConnection == 0)
{
    std::cout << "Error accepting connection\n\n" << std::endl;
}
else
{
    std::cout << IP << " successfully connected to the client.\n\n" << std::endl;

    std::ifstream fl("C:\\readbyte.exe");
    fl.seekg(0, fl.end);
    int length = fl.tellg();
    char *buffer = new char[length];
    fl.seekg(0, fl.beg);
    fl.read((char*)buffer, length);
    fl.close();
    std::cout << buffer << std::endl;
    send(newConnection, (char*)buffer, length, 0);

}

And here is my code for writing the bytes to a new EXE file:

if (connect(Connection, (SOCKADDR*)&addr, sizeof(addr)) != 0) // if we are unable to connet
{
    MessageBoxA(NULL, "Failed to connect", "Error", MB_OK | MB_ICONERROR);

}
else
{
    std::cout << "Connected to server.\n" << std::endl;

    std::vector<char> file(11776);
    std::cout << "Test1" << std::endl;
    if (recv(Connection, (char*)&file[0], file.size(), 0) < 0)
    {
        std::cout << "Test2" << std::endl;
        puts("Recv failed\n");
        system("pause");
        return -1;
    }
    else
    {
        std::cout << "Test3" << std::endl;
        std::cout << "File recieved: " << std::endl;

        /*for (int i = 0; i < file.size(); i++)
        {
            std::cout << file[i];
            if (int(file[i]) == 0)
            {
                file.erase(file.begin() + i);
            }

        }*/
        const char *path = "C:/Users/Public/writefile.exe";
        std::ofstream fout(path, std::ios::binary | std::ios::out);
        fout.flush();
        fout.write((char*)&file[0], file.size());
        fout.close();


        std::cout << "File size is: " << file.size() << std::endl;

        closesocket(Connection);
    }

I'm not sure what I am doing wrong. I've been working on this for 2 days now.

EDIT: ANSWER

std::ifstream fl("C:\\readbyte.exe", std::ios::out | std::ios::binary);

I forgot to include std::ios::out | std::ios::binary std::ios::out | std::ios::binary in the server ifstream . I also switched the out and binary arguments around.

Answer 1

以二进制模式打开文件（将std::ios::binary作为ifstream第二个参数）