从params创建新哈希的方法是什么？

Question

I'm trying to create a new hash from params . I'm doing something like this:

where_query = { active: true }
where_query[:brand_ids] = params[:brand_ids].split(',') if params[:brand_ids].present?
where_query[:market_id] = params[:market_id] if params[:market_id].present?

Is that okay? Or is there a better way to do that?

Answer 1

I would go with more explicit declaration:

where_query =
  { 
    active: true,
    brand_ids: params[:brand_ids].try(:split, ','),
    market_id: params[:market_id]
  }.select { |_, v| v.present? }

---

Modern version of the above (Ruby 2.4+ required):

where_query =
  { 
    active: true,
    brand_ids: params[:brand_ids]&.split(','),
    market_id: params[:market_id].presence
  }.compact