尝试使用var而不是数字简化javascript。 我要解决所有这些错误吗？

Question

I'm trying to make my FizzBuzz do calculations using modulus by variable in order to simplify the code. They are supposed to count up to 140 displaying True or False.

My previous 'if' statement looks like this (and it worked) :

if (i % 3 === 0 && i % 5 === 0)

The example that I've seen looks like this:

if (checkDivision(iCounter, secondDivisor))

I've created variables for the counter, the two divisors, and the modulus checker, but I can't seem to get it to work.

Any help is appreciated because I am still very new to javascript and coding in general.

Here is my code so far:

    function clickAlert2() {
  var firstDivisor = 3;
  var secondDivisor = 5;
  for (var iCounter = 1; iCounter <= 140; iCounter++) {
    var checkDivision =
      iCounter % firstDivisor === 0 || iCounter % secondDivisor === 0;
    if (checkDivision(iCounter, firstDivisor)) {
      document.getElementById("ngList").innerHTML +=
        checkDivision + ". True [3] <br>";
    } else if (checkDivision(iCounter, secondDivisor)) {
      document.getElementById("ngList").innerHTML +=
        checkDivision + ". True [5] <br>";
    } else {
      document.getElementById("ngList").innerHTML +=
        checkDivision + ". False <br>";
    }
  }
}

EDIT----------------------------------------------------------------------------

Alright, so now my only problem is that the numbers that should be divisible by five, are being displayed as divisible by three when clearly that isn't possible:

    function clickAlert2() {

  function checkDivision(counter) {

    var firstDivisor = 3,
      secondDivisor = 5;

    return (counter % firstDivisor === 0) || (counter % secondDivisor === 0);
  };

  for (var iCounter = 1; iCounter <= 140; iCounter++) {

    if (checkDivision(iCounter)) {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". True [3] <br>";
    } else if (checkDivision(iCounter)) {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". True [5] <br>";
    } else {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". False <br>";
    }
  }
}

Answer 1

Your checkDivision is a Boolean variable and not a function. So you simply pass it as the expression in the if and else if statements.

if(checkDivision){.....}

Also, for a fizzbuzz you could make a function like this.

function fizzbuzz(num){
  if(num % 3 === 0 && num % 5 === 0)
     return "FizzBuzz";
  else if(num % 3 === 0)
     return "Fizz";
  else if(num % 5 === 0)
     return "Buzz";
  else return "none";
}

Now you can compare the string returned by this function to know exactly whether it is a fizz, or Buzz, or a fizzbuzz

Answer 2

I can realize from your code segment you are trying to detect the numbers between 1 - 140 which are divisible by 3( firstDivisor ) and 5( secondDivisor ). you need loop which go through 1 -140 and a function ( checkDivision ) function which determine given number is the number divisible by 3 and 5.

function clickAlert2() {

  function checkDivision(counter, divisor) {

    return (counter % divisor === 0);
  };

  var firstDivisor = 3,
    secondDivisor = 5;

  for (var iCounter = 1; iCounter <= 140; iCounter++) {

    //check divsible by both divisors
    if (checkDivision(iCounter, firstDivisor) && checkDivision(iCounter, )) {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". True [" + firstDivisor + " " + secondDivisor + "] <br>";
    }

    //check divible by first divisor
    else if (checkDivision(iCounter, firstDivisor)) {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". True [" + firstDivisor + "] <br>";
    }
    //check divible by second divisor
    else if (checkDivision(iCounter, secondDivisor)) {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". True [" + secondDivisor + "] <br>";
    }
    //cannot divisible either divisors
    else {
      document.getElementById("ngList").innerHTML +=
        iCounter + ". False <br>";
    }
  }
}

Answer 3

Is this what you are looking for?

 function clickAlert2() { var firstDivisor = 3; var secondDivisor = 5; var checkDivision = function (counter, divisor) { return counter % divisor === 0; }; for (var iCounter = 1; iCounter <= 140; iCounter++) { if (checkDivision(iCounter, firstDivisor)) { document.getElementById("ngList").innerHTML += iCounter + ". True [3] <br>"; } else if (checkDivision(iCounter, secondDivisor)) { document.getElementById("ngList").innerHTML += iCounter + ". True [5] <br>"; } else { document.getElementById("ngList").innerHTML += iCounter + ". False <br>"; } } } clickAlert2() 

 <div id="ngList"></div>