使用Post方法Rest + SpringBoot

Question

I have been searching all morning and i think i'm missing something .
i have a Spring boot controller with a method to save a client.
this is the method :

// ajouter un client
@RequestMapping(value="/AjoutClient/{clientData}", method=RequestMethod.POST)
public String AjoutClient(@PathVariable String clientData) {

    Client c = new Client();
    c.setNomClient(clientData.split(";")[0]);
    c.setPrenomClient(clientData.split(";")[1]);
    c.setAdresseClient(clientData.split(";")[2]);
    c.setTelClient(clientData.split(";")[3]);
    c.setEmailClient(clientData.split(";")[4]);
    c.setCinClient(clientData.split(";")[5]);

    client.save(c);
    return "test";
}

i want to consume this method from another application with this method :

@RequestMapping(value="/ajoutClient", method=RequestMethod.POST)
 public void ajout(@RequestParam("nom") String nom,@RequestParam("prenom") String prenom,@RequestParam("adr") String adr,@RequestParam("tel") String tel,@RequestParam("mail") String mail,@RequestParam("cin") String cin) {

    String ClientData=nom+";"+prenom+";"+adr+";"+tel+";"+mail+";"+cin;

     RestTemplate restTemplate = new RestTemplate();

     HttpEntity<String> request = new HttpEntity<>(new String(ClientData));
     ResponseEntity<String> response = restTemplate
       .exchange("http://localhost:9093/AjoutClient/"+ClientData, HttpMethod.POST, request, String.class);

     assertThat(response.getStatusCode(), is(HttpStatus.CREATED));

  }

** explication : i get the values from a form and construct a string with those values, then try to send that string to my clientController.
PS: i can't send client object, i have to send the values one by one then create the client object in the clientController.
i'm feeling pretty lost because i can see that something is wrong but i don't know what is it.

Answer 1

First of all I would suggest you avoid using @PathVariable for passing the data like this. You're already sending everything in the request body, so first step is to change:

public String AjoutClient(@PathVariable String clientData) {

to

public String AjoutClient(@RequestBody String clientData) {

and

restTemplate.exchange("http://localhost:9093/AjoutClient/" + ClientData, HttpMethod.POST, request, String.class);

to just

restTemplate.exchange("http://localhost:9093/AjoutClient", HttpMethod.POST, request, String.class);

Then if you're expecting 201 status then you have to return it:

public ResponseEntity<String> AjoutClient(@RequestBody String clientData) {
    ...
    return ResponseEntity.created(null).body("test");
}

PS: Please pay attention to what @JB Nizet mentioned, cause he has a point here. Just research that keywords (google them) or read some tutorials eg https://www.baeldung.com/java-url-encoding-decoding or https://www.baeldung.com/rest-template and you'll easily find out more about standard practices.