如何修复将数据插入第二张表

Question

I am trying to insert the same data into the second table based on the first table created UserID (auto-increment).

I created an INSERT query which inserts the user registration data into the users_tb table. It works successfully. Then I need to insert the address describing data into the address_tb table, based on the UserID in users_tb . But unfortunately it doesn't work.

//Rady to insert:
$results = $Street. ", " .$Apt. ", " .$City. ", " .$State. ", " .$ZipCode. ", " .$Country; 
$query = mysql_query("INSERT INTO users_tb (UserId , FirstName , LastName , Email , Username , Password , Street , Apt , City , State , ZipCode , Country , Address , HomePhone , MobilePhone , Lat, Lng, Membership) VALUES ('' , '$First_Name' , '$Last_Name' , '$Email' , '$Username' , '$hashedPW' , '$Street' , '$Apt' , '$City' , '$State' ,'$ZipCode' ,'$Country' , '$results' , '$Ph_Number' , '$Mb_Number' , '0' , '0' , '1')");

// Insert Data into address_tb
$ad = mysql_query("SELECT UserID , Username FROM users_tb WHERE Username = $Username");
$adad = mysql_fetch_row($ad);
$UserID = mysql_real_escape_string($adad['UserID']);
$query = mysql_query("INSERT INTO address_tb (AddressID , Street , Apt , City , State , ZipCode , Country , Address , Lat , Lng , UserID) VALUES ('' , '$Street' , '$Apt' , '$City' , '$State' ,'$ZipCode' ,'$Country' , '$results' , '0' , '0' , '$UserID')");

I need to have the address fields also in my address_tb table with the respective UserID .

Answer 1

$Username should be enclosed in single quotes since it's a string.

$ad = mysql_query("SELECT UserID , Username FROM users_tb WHERE Username = '$Username'");

Second problem is, [mysql_fetch_row][1] returns enumerated array ie key as numeric indexes. Change is mysql_fetch_assoc .

$adad = mysql_fetch_assoc($ad);

Another approach is to get last insert id and use it to add address. After inserting into users table, use below method to retrieve last user id

$last_user_id = mysql_insert_id();

Use $last_user_id directly into the insert query on address_tb .

Please note mysql is deprecated. You should use mysqli with parameterized queries ( https://www.w3schools.com/php/php_mysql_prepared_statements.asp ).

Answer 2

This can be done in 1 query, using INSERT SELECT :

INSERT INTO address_tb (AddressID,
                        Street,
                        Apt,
                        City,
                        State,
                        ZipCode,
                        Country,
                        Address,
                        Lat,
                        Lng,
                        UserID)
SELECT (AddressID,
        Street,
        Apt,
        City,
        State,
        ZipCode,
        Country,
        Address,
        Lat,
        Lng,
        UserID)
FROM users_tb
WHERE users_tb.Username = ?;

Answer 3

I did it. Thank you all of you. To tell the truth I didn't understand what was the reason that the second INSERT query didn't complete the data in address_tb. I only took the first query and edited as the second query and it starts working. As I see there aren't any differences in my new query, which I got from editing the first one. Here is my second query:

<< $sql2 = mysql_query("INSERT INTO address_tb (AddressID , Street , Apt , City , State , ZipCode , Country , Address , Lat , Lng , UserId) VALUES ('' , '$Street' , '$Apt' , '$City' , '$State' ,'$ZipCode' ,'$Country' , '$results' , '0' , '0' , '$UserID')"); >>