我应该使用Promise.All而不是async.each吗？

Question

Currently using async.each to build array. I wonder if there is alternative approach using es6? Should I use Promise.All?

async pushDataArray(response) {
    if (response && response.data && response.data.length > 0) {
        async.each(response.data, (data, error) => {
            if (this.messagesData.length < this.maxCount) {
                this.messagesData.push(data);
            }
        });
    }

    return this.messagesData;
}

Usage:

await this.pushDataArray(response);

Answer 1

No, you should not use neither. There is nothing asynchronous in your code. Just write

pushDataArray(response) {
    if (response && response.data) {
        for (const data of response.data) {
            if (this.messagesData.length < this.maxCount) {
                this.messagesData.push(data);
            }
        });
    }
    return this.messagesData;
}

or even simpler

pushDataArray(response) {
    if (response && response.data) {
        this.messagesData.push(...response.data.slice(0, this.maxCount - this.messagesData.length));
    }
    return this.messagesData;
}