仅重定向一次并保存访问者IP

Question

the code works fine but when it has 200 ip stored it deletes it automatically and I want it to not delete any ip unless I delete them manually

$ipfile = "ips.txt";
$ips = explode("\n",file_get_contents($ipfile));
$isban = 0;
foreach($ips as $ip) {
    $ip = explode(" ",$ip,2);
    if($_SERVER['REMOTE_ADDR'] == $ip['0']) {
        $isban++; 
    }
}
if(!empty($isban))
{
    die("IP IS BANNED!");
}
else
{
    $ips[] = $_SERVER['REMOTE_ADDR']." ".date("d/m/y");
    $ips = implode("\n",$ips);
    file_put_contents($ipfile,$ips);
    header('Content-Type: text/html; charset=UTF-8');
    header('Location: http://www.google.com/');
    exit;
}

I want it to store all the ip without deleting it, it does not matter if I have to use a database so that it can work better or some solution that someone brings to me.

Answer 1

This code has no error handling, therefore it is impossible to learn early about what fails so that you can't address it specifically.

What does that mean? Let's see exemplary this line of code (I've taken it from the code of your question, but I could have taken it from numerous other examples, as such kind of a mistake is quite common in PHP code examples on Stackoverflow):

$ips = explode("\n",file_get_contents($ipfile));

If file_get_contents() fails to load the file it normally is only noticed if you expect the list of $ips has entries and then unexpectedly it does not.

That is because the return value of file_get_contents() is not checked whether or not an error appeared.

In PHP it is quite common that a function not only returns the result of the function but as well - in case of an error - the error result of it.

For every function which differs that way in the return value, it needs to be treated for the different ways.

This is especially crucial w/ i/o operations like reading from a file and writing to a file. you actually want to learn when these operations fail and then proceed accordingly.

To repeat the example: If reading the file fails, this is not an empty string to progress with resulting in data-loss of all recordsets (in your case your file actually is a database and one record is one line in it). But if not treated differently, it will become so, which is in your example the deletion of all IPs.

How To Solve?

Review the use of I/O related functions in the code. This can be easily achieved by going through each function call and check the manual entries regarding their error handling and especially the return values.

Then improve your code by handling these error conditions accordingly.

Further Outlook

Next to error handling there is also something called locks or locking regarding file operations, you could take a read into that to better control congruent execution of the same script as the file is a shared resource here.

Answer 2

it is much easier using database. Here is example.

In Mysql:

CREATE DATABASE addr;
USE addr;

CREATE TABLE ips (
  id INT AUTO_INCREMENT PRIMARY KEY,
  ip VARCHAR(45),
  visit_timestamp TIMESTAMP DEFAULT now()
);

In PHP:

$conn = new mysqli('localhost','username','password','addr');

$remote_ip = $_SERVER['REMOTE_ADDR'];

$query2 = "SELECT * FROM ips WHERE ip = '$remote_ip'";

$isban = mysqli_num_rows($conn ->query($query2));


if($isban > 0){
    die("IP IS BANNED!");
}
else{

    $query = "INSERT INTO ips (ip) VALUE ('$remote_ip')";

    $conn->query($query);

    header('Content-Type: text/html; charset=UTF-8');
    header('Location: http://www.google.com/');
    exit;
}