Windows 批处理脚本“系统找不到指定的文件。” 文件名中有感叹号？

Question

I am trying to write a batch script that does the following:

When a folder is drag-and-dropped onto the batch script, it processes every file in that folder.

I am running into a problem with a certain filenames that contain exclamation marks. eg:

!.txt or !!!.txt

For now, I am simply trying to rename the file to demonstrate the issue:

@echo off

SetLocal EnableDelayedExpansion
set folder=%~1
set count=0

for /r "%folder%" %%G in (*) do (
    set fullpath=%%G
    set fileExtension=%%~xG
    call :processFile
)
goto end

:processFile
    echo "fullpath = %fullpath%"
    echo "fileExtension = %fileExtension%"

    rename "%fullpath%" "temporary_filename_500%fileExtension%"

    set /a count+=1
echo.
    goto :eof

:end

echo "%count% files processed."

pause

It gives me the error "The system cannot find the file specified." However, it works if I change the filename to something simple like "test.webm" How can I make the script more robust?

Answer 1

I don't see that you are using somewhere delayed expansion. So, either disable it with setlocal DisableDelayedExpansion in the start of your batch file or just remove it by removing line setlocal EnableDelayedExpansion .

However, if you want to keep it, do:

@echo off

SetLocal EnableDelayedExpansion

rem Code above (^^) if exists.

Setlocal DisableDelayedExpansion

set "folder=%~1"
set "count=0"

for /R "%folder%" %%G in (*) do (
    set "fullpath=%%~fG"
    set "fileExtension=%%~xG"
    call :processFile
)
goto end

:processFile
echo "fullpath = %fullpath%"
echo "fileExtension = %fileExtension%"

ren "%fullpath%" "temporary_filename_500%fileExtension%"

set /a "count+=1"
echo/
goto :eof

:end
echo "%count% files processed."
pause
setlocal EnableDelayedExpansion

rem Your code below with active delayed expansion:

Note that:

• You should always quote the variable name and the value in the set command like set "var=value" and in set /a like set /a "var+=1" , etc.; see set /? for more information.
• To find the full path of a file/folder for sure in a for loop, use the f modifier, like %%~fG .
• Mentioned by Mofi here : don't use echo. ; use echo/ for better practice.

See also the Phase 5 (Delayed Expansion) of this answer about how batch files are interpreted.