如何从指向指针数组的指针中删除对象？

Question

I'm still new to manual destruction in C++ (came from languages with garbage collection). I have the following in one of my classes:

Input** Inputs;

Which gets initialized as follows:

this->Inputs = new Input* [totalInputs];

And can get reassigned to later on in my code depending on user input, similar to this:

this->Inputs[inputNumber] = new DigitalInput(params...)

The problem with this is that it's open to memory leaks when reassigning the object at that location due to releasing the old object.

What is the best way to delete the old object once it's been reassigned?

Edit: I forgot to include that this is on an AVR microcontroller which is running on the Arduino codebase.

Edit 2: The reason that I'm doing this this way is because the user is allowed to send commands to the unit which will change the input type (ie: send a command and this->Inputs[inputNumber] = new AnalogInput(params...) . Also the reason it's a pointer to an array of pointers is because the constructor for this object will generate that array based on the totalInputs argument passed in. This is in a shared library which is used on a few different units.

Answer 1

Its best not to use the raw pointers at all and go for stl containers. One possible way could be as below.

using InputPtr = std::unique_ptr<Input>;
std::vector<InputPtr> Inputs;
Inputs.emplace_back(std::make_unique<DigitalInput>());

No need to worry about memory leaks any more. The other option you have is to use std::shared_ptr depending upon how you intend to use your InputList;

Answer 2

If you're reassigning a member of the array to point to a new object, you can first deallocate the old object, if any.

Input* oldInput = this->Inputs[inputNumber];
delete oldInput;

this->Inputs[inputNumber] = new DigitalInput(params...)

Answer 3

If you want to delete objects in the heap:

for(int i = 0; i < totalInputs; ++i) delete Inputs[i]; delete[] Inputs for(int i = 0; i < totalInputs; ++i) delete Inputs[i]; delete[] Inputs ;

Edit: If you're using a microcontroller it would be best to allocate at the stack instead.

Define a maximum size on your array. Like:

const int MAX = 5;
Inputs inputs[MAX][MAX];

then just asign objects to it.