函数未检测到 EOF

Question

Function get_word is supposed to read word from stdin and save it. Saving next word after white char and return EOF on EOF but I am still getting in infinite loop. htab_lookup_add is some function to save word into table. There also seems to be a problem "Too long message" never prints but that's not the problem I am trying to solve now.

int get_word(char *s, int max, FILE *f){
    s = malloc(sizeof(char) * max);

    int c;
    int i = 0;
    while((c = getc(f))){
        if(i > max || isspace(c)){
            break;
        }
        s[i++] = c;
    }
    s[i] = '\0';

    if(c == EOF){
        return EOF;
    }
    return i;
}


while(get_word(word, (maxchar + 1), stdin) != EOF){
    if(strlen(word) > maxchar){
        printf("Too long!\n");
    }
    htab_lookup_add(table, word);
}

Answer 1

This loop:

while((c = getc(f))){
    ...
}

will terminate only when getc() returns zero, ie, when it reads a null character '\\0' . And when it returns EOF you'll store that value (converted to char ) in s[i] and continue looping.

The test for EOF after the loop will never match.

You need to end the loop when it returns EOF . The usual idiom is:

while ((c = getc(f)) != EOF) {
    ...
}