onClick 和 className 在 reactjs 中不起作用

Question

Onclick does not work in this component. This is the first time I have ever encountered this error, I have tried going through the code, I have bound all functions to this and yet onClick method is not working at all. Any className that I add to the div inside the Col is not being applied too.

import React, { Component } from 'react';
import { connect } from 'react-redux';
import { Row, Col } from 'antd';
import { safariTypes }  from '../../data/safariTypes';
import uuid from 'uuid/v1';
import '../../App.css';
const ThePeople = './Media/thePeople.jpeg';
const BoraBora = './Media/bora.jpg';
const Aerial = './Media/balloon.jpg';
const Family = './Media/family_small.jpg';
const Honeymoons = './Media/honeymoon_small.jpg';
const Wildlife = './Media/wildlife.jpg';


    class Highlights extends Component {
    constructor(props) {
        super(props);
        this.state = {

        }
        this.returnSafariItemsHighlights = this.returnSafariItemsHighlights.bind(this)
        this.show = this.show.bind(this)
    }
show = () => {


     console.log("hey");

 }

    returnSafariItemsHighlights(){

        var Feature = null

        var arr = []
        if(safariTypes){
            safariTypes.slice(0,6).map((item, key) => {
                if(item === 'Aerial e.g Hot air ballons'){
                    Feature = Aerial
                } else if(item === 'Wildlife') {
                    Feature = Wildlife
                } else if(item === 'Family and Holiday') {
                    Feature = Family
                } else if(item === 'Beach Holidays') {
                    Feature = BoraBora
                } else if(item === 'Culture and History') {
                    Feature = ThePeople
                } else if(item === 'Honeymoons'){
                    Feature = Honeymoons
                } 


                arr.push(

                <Col  xs={24} sm={12} md={12} lg={8} xl={8}  key={uuid()} onClick={this.show} >
                <div 
                className="bounceAnimation"  
                style={{ backgroundImage: 'url(' + Feature + ')', 
                backgroundSize: 'cover', 
                backgroundPosition: 'center center',
                backgroundRepeat: 'no-repeat',
                height: '40vh',
                paddingTop: '28vh',
                paddingLeft: '20px',
                paddingRight: '20px'
              }}>

                <div  style={{backgroundColor: "rgb(255, 255, 255, 0.4)", textAlign: "center", fontSize: "25px",padding: "5px", fontFamily: "Lobster", color: "green"}}>

                #{item}

                </div>
                </div>

                </Col>


                )
            })
        }
        return arr
    }
  render() {

    return (
      <div>{this.returnSafariItemsHighlights()}</div>


    );
  }
}

Answer 1

it seems Col does not accept onClick prop, why don't you move onClick={this.show} to the div inside Col as follows

<Col
  xs={24} sm={12} md={12} lg={8} xl={8}  key={uuid()} >
  <div 
    onClick={this.show}
    className="bounceAnimation"  
    style={{ backgroundImage: 'url(' + Feature + ')', ...}}
  >
     ...
  </div>
</Col>

I think I found a performance issue, every time the component renders it will call returnSafariItemsHighlights , there you populate an array of components with a key prop which is generated every time you call the function, when react reconciles it will find different keys in that case child components will not be reused.