c 程序中的分段错误，使用 malloc (Linux os)

Question

this c program works in Windows But Getting " Segmentation fault (core dump)" in Linux. I gues couse of error pointers or malloc function.I can't return struct array without pointers and malloc.

struct team {
    char name[12];
    int m_count;
    int score;
};

struct team *teamName(){        

    FILE *fp;
    fp=fopen("teams.txt", "r");

    struct team *items; 
    items= (struct team *) malloc(sizeof(struct team) * 10);

    int i;
    for(i=0; i<10; i++)
    {
        fscanf(fp, "%s\n" , items[i].name); 
    }

    fclose(fp);
    return items;
}

int main(void)
{   struct team *items = teamName();    
    getMatch(items);
}

Answer 1

There several problems in your code :

• you do not check fopen success

• you do not check fscanf success, and if a read name is greater than 11 you write out of the buffer with an undefined behavior

• why the \\n in the fscanf format ?

• if you read less that 10 names some entries are not set, with the risk later to have an undefined behavior

---

A proposal taking my remarks into account can be :

#include <stdio.h>
#include <stdlib.h>

struct team {
  char name[12];
  int m_count;
  int score;
};

struct team *teamName(){        
  FILE *fp = fopen("teams.txt", "r");

  if (fp == NULL)
    return NULL;

  struct team *items = malloc(sizeof(struct team) * 10);

  int i;

  for (i=0; i<10; i++)
  {
    if (fscanf(fp, "%11s" , items[i].name) != 1) {
      /* empty other names */
      do {
        items[i].name[0] = 0;
      }
      while (++i != 10);
      break;
    }
  }

  fclose(fp);
  return items;
}

int main(void)
{
  struct team *items = teamName();

  if (items != NULL) {
    for (int i = 0; i != 10; ++i) {
      if (items[i].name[0] != 0)
        puts(items[i].name);
    }
  }

  /* getMatch(items); */
}

Compilation and execution :

pi@raspberrypi:/tmp $ gcc -pedantic -Wextra -Wall m.c
pi@raspberrypi:/tmp $ cat teams.txt 
aze qsd
loop
bar
pi@raspberrypi:/tmp $ ./a.out
aze
qsd
loop
bar
pi@raspberrypi:/tmp $ 

Note the fscanf read words, I mean a name must not contain space, else you need to use for instance fgets