Java龙目岛 - 最佳实践？

Question

I have inherited a class with the following Lombok annotations:

@Getter
@Setter
@Builder
@NoArgsConstructor
@AllArgsConstructor
@ToString
@EqualsAndHashCode
public class PricingAndCosting {

//variables and constants

}

is it better practice to just do the following to get the same functionality:

@Entity
@Data
public class PricingAndCosting {

//variables and constants

}

Answer 1

The class you had inherited is only 1 step removed from being fully open to the outside (it would require making the fields public ) which is potentially bad as few bugs could hide in uses of this class. Even if the class is being consumed in sane way, you cannot guarantee it into the future unless you close it off a bit.

You can construct it with no values, with all values, you can build it with only some values and you can mutate it through setters.

This most likely breaks the equals and hashcode contract too (those should be calculated using the same set of immutable fields - a very rough rule of thumb which makes sense when using lombok, but obviously there is more).

I would first identify the uses of this class and find out whether it can be refactored to something closer to immutable.

Answer 2

Short answer is it depends. Long answer is in general, Lombok is generating code for you to avoid boilerplate code, however, you should know what you really need to use? suppose you need only getters then use @Getter.

Moreover, sometimes it is really helpful for you; something which is common heavily uses like Builder pattern can be offered to you with just one annotation, and also Throwing an exception is another fancy feature and more and more. You can check this to see a good example https://www.baeldung.com/intro-to-project-lombok

As code efficiency; it sounds that using little code with @Data will be better, but actually, it is not! you are consuming resources which you may not need. So try to use what you really need is a good practice.