array.select不遍历每个元素

Question

I have a rails controller and this code only loop through the first element in the metrics array? Why is that?

# /metrics/:id
def values
  @metric = metrics.select do |metric|
    id = metric['href'].split('/').last
    p "id == params[:id] = #{id == params[:id]}" # false on the first iteration (but never gets to the next iteration
    return id == params[:id]
  end
  p "HERE?" # We never get here!
end

Answer 1

You need to remove the return statement from your method, Ruby uses implicit return (see https://jtrudell.github.io/blog/ruby_return_values/ ), so the result of a block is the last line that is evaluated in that block, the return statement in your code is treated as a return from the values method. Your method needs to look something like:

def values
  @metric = metrics.select do |metric|
    metric['href'].split('/').last == params[:id]
  end
end