当我尝试创建此过程时，如何解决此错误“ ERROR 102 sql state 420000”

Question

I am trying to create a procedure which check whether the number entered (as a nvarchar type) already exists or not. If it exists then the updation takes place, else an error is thrown out to the user. But am not able to create the procedure because as soon as I execute the command ERROR 102/156 SQL STATE 42000 comes up.

CREATE PROCEDURE UpdateAWBUnique
(
    @AWB as nvarchar,
    @Internal as nvarchar
)
AS
BEGIN
    SET NOCOUNT ON
    if((SELECT count(*) From Def_tab WHERE AWB=@AWB) == 0) 
    BEGIN
        UPDATE Def_tab SET AWB= @AWB
        where Internal=@Internal
    END
    ELSE
    BEGIN
        PRINT 'Already Exits'
    END
END
GO

FYI I use Microsoft SQL Server. How to clear this error and create the procedure?

Answer 1

Conditionally UPDATE and see if any changes happened

    UPDATE Def_tab 
    SET AWB = @AWB
    WHERE Internal = @Internal 
         AND NOT EXISTS (SELECT 1 FROM Def_tab t WHERE t.AWB= @AWB)
    IF (@@ROWCOUNT = 0)
        PRINT 'Already Exits'

Otherwise in a concurrent environment something may happen between

if((SELECT count(*) From Def_tab WHERE AWB=@AWB) == 0) 

and

BEGIN
    UPDATE Def_tab SET AWB= @AWB

renderring the if check useless

Answer 2

You seem to want Def_Tab.AWB to be unique. If so, you should let the database enforce the data integrity. Define a unique constraint:

alter table t add constraint unq_def_tab_awb
    unique (awb);

No stored procedure is needed.

This will also check the value on insert . And because the database is doing the check, you don't have to worry about whether or not the stored procedure is actually called when someone updates the table.