如果细胞是某种其他颜色，如何更改它们的颜色？

Question

I have written a short Macro to change cells of a given colour to another colour in a workbook. This code throws no errors however it simply does nothing.

I have already tested the colour codes to see if they are correct using MsgBox ActiveCell.DisplayFormat.Interior.color

Option Explicit

Sub Recolour()
    Application.ScreenUpdating = False
    Dim Sheet As Worksheet
    Dim Rng As Range
    Dim OldColour As Variant
    Dim NewColour As Variant
    Dim Cell As Range

    Set Rng = ActiveSheet.Range("A1:Y457")
    OldColour = 128
    NewColour = RGB(134, 38, 51)

    For Each Sheet In ThisWorkbook.Worksheets

        For Each Cell In Rng.Cells

            If ActiveCell.DisplayFormat.Interior.Color = OldColour _
                Then _
                Set ActiveCell.DisplayFormat.Interior.Color = NewColour _
            Else

        Next Cell

    Next Sheet

    Application.ScreenUpdating = True

End Sub

This is probably something simple and daft however I need to ask.

Answer 1

DisplayFormat is read-only. If you want to change the property, you need to drop DisplayFormat . Also, if you are using For each Cell , then you should refer to Cell , not ActiveCell .

For Each Sheet In ThisWorkbook.Worksheets
    For Each Cell In Rng.Cells
        If Cell.Interior.color = OldColour Then 
            Cell.Interior.color = NewColour
        End if    
    Next Cell
Next Sheet

Answer 2

You only need to Set object variables in VBA, your if statement is also problematic. Try:

For Each Sheet In ThisWorkbook.Worksheets
    For Each Cell In Rng.Cells
        If ActiveCell.DisplayFormat.Interior.color = OldColour Then 
            ActiveCell.DisplayFormat.Interior.color = NewColour
        End if    
    Next Cell
Next Sheet