单元测试：茉莉花

Question

isTriangle function checks the sides of the triangle and determines if the triangle is either a scalene, equilateral, or isosceles.

After writing the function, I need to do an unit test via Jasmine with Javascript.

Code:

function isTriangleTranslate(side1, side2, side3) {
    if (side1 === side2 && side3 === side2 && side2 === side1) {
        return ("It's an equilateral!");
    }
    if (side2 === side3 && side1 != side2 && side1 != side3 || side1 === side3 && side2 != side1 && side2 != side3 || side1 === side2 && side2 != side3) {
        return ("It's an isosceles!");
    }
    else {
        return ("It's a scalene!");
    }
}

Spec:

describe("isTriangle", function(){

  it("is an equilateral trinagle with three equal sides", function(){
    expect(isTriangleTranslate()).toEqual("It's an equilateral!");

  })

});

describe("isTriangle", function(){

  it("is an isosceles triangle with two equal sides", function(){
    expect(isTriangleTranslate()).toEqual("It's an isosceles!");

  })

});

describe("isTriangle", function(){

  it("is a scalene triangle with no equal sides", function(){
    expect(isTriangleTranslate()).toEqual("It's a scalene!");

  })

});

Errors are that the scalene & isosceles do not equal "It's an equilateral"

I do not want it to do that. I want it to determine if my side1, side2, & side3 are equal then it equals the string "It's an equilateral!"

If my side1, side2, & side3 have two sides that are equal the it equals the string "It's an isosceles!"

Else, the triangle is "It's a scalene!"

How will you write this in a unit test for Jasmine?

Answer 1

First, I would simplify the function, just on general principles:

function isTriangleTranslate(a, b, c) {
   if (a === b && b === c && c === a) {
      return ("It's an equilateral!")
   } 
   else if (a+b == a+c || b+a == b+c || c+a == c+b) {
        return ("It's an isosceles!");
   } else {
        return ("It's a scalene!");
   }
}

Then, I would pass values into the test. You were just invoking the method with no arguments.

describe("isTriangle", function(){

  it("is an equilateral triangle with three equal sides", function(){
    expect(isTriangleTranslate(4,4,4)).toEqual("It's an equilateral!");
  })

});

describe("isTriangle", function(){

  it("is an isosceles triangle with two equal sides", function(){
    expect(isTriangleTranslate(4,4,5)).toEqual("It's an isosceles!");
  })

});

describe("isTriangle", function(){

  it("is a scalene triangle with no equal sides", function(){
    expect(isTriangleTranslate(4,5,6)).toEqual("It's a scalene!");
  })

});