我遇到声纳建议问题，即Method有8个参数，大于我的代码中授权的7个

Question

I am facing sonar issue in my below code.

Where sonar suggests that Method has 8 parameters, which is greater than 7 authorized. So how can we solve this issue by putting this parameters in array or map?

private void appendSchemeSpecificPart(StringBuilder sb,
    String opaquePart,
    String authority,
    String userInfo,
    String host,
    int port,
    String path,
    String query
)

I am not able to make array and pass it to this method appendSchemeSpecificPart() .

Can someone help on this?

Answer 1

Don't use an array to pass several objects that have different semantics.
It is very very error prone.
Instead of, extracting parameters with high cohesion in a class : SchemeSpecificPart and define it as a parameter such as :

void appendSchemeSpecificPart(StringBuilder sb, SchemeSpecificPart schemeSpecificPart){..}  

The StringBuilder is not a part of the SchemeSpecificPart concept. So we will not define it in.

Now you can invoke your method :

StringBuilder sb = ...;
SchemeSpecificPart part = ...;
appendSchemeSpecificPart(sb, part);  

---

Not your question but note that modifying the parameters state (here StringBuilder sb )through invoked methods is a unsafe approach.
It gives to the appendSchemeSpecificPart() method more responsibilities than it needs. For example, the method could remove existing content for sb while it should not be able) and it also may make harder to understand what each method that accepts the StringBuilder does really since all methods can overwrite the things done by the previous.

Returning a String appears more clear and robust :

String computeSchemeSpecificPart(SchemeSpecificPart schemeSpecificPart){...}

And use it :

SchemeSpecificPart part = ...;
StringBuilder sb = ...;  
sb.append(computeSchemeSpecificPart(part));

Answer 2

The combination of host and port is called a socket address. There is already a class for holding this pair of values: InetSocketAddress .

By combining 2 parameters into 1, you will not exceed the threshold. You could also see whether other related parameters could be combined.

It almost looks like String host, int port, String path, String query are in fact just a URL, but hard to say without seeing the implementation.

Answer 3

It's best to understand why you have that issue.

From sonar, this is classified under brain overload - the goal is to make the code easier to read and understand.

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Try encapsulating some of those fields in a different class and pass an instance of that class to your method.