用户不想要照片时邮件附件出现错误

Question

I've got a cake order form for my website and part of it allows the user to decide whether or not they want a photo on their cake. When they complete the form and it is confirmed the order is created on my sql table and they are sent an email confirmation, in the email is an attached pdf and the photo they want (if they choose to have one). This works if they do want a photo but I get an error if they decide they don't want one.

This is the html for the photo part of the form:

<p>Would you like a photo on your cake?(£7)</p>
<div>
<label class="checkbox-inline"></label>
    <input type="radio" name="photo[]" class="photo" id="photo[]" value="7">Yes
</label>
<label class="checkbox-inline">
<input type="radio" name="photo[]" class="photo" id="photo[]" value="0"/>No
</div>

</label>
<br /><br />
<div class="7 box" style="display: none;">
<input type="file" name="image" id="image" onchange="readURL(this);" accept="image/*"/>
 <img id="cakePhoto" src="#" />

 </div>

 <div class="0 box" style="display: none;">
 <p>You do not want a photo on your cake</p>
 </div>

The reason for the div classes is because one will appear depending on what the user decides, if they choose yes then the file input appears, but if they choose no then the "You do not want a photo on your cake" appears

I am using $_SESSION for storing the values as I need them on a couple different pages but this is how I am storing the photo uploaded by the user:

$filename    = $_FILES["image"]["tmp_name"];
  $destination = "uploads/" . $_FILES["image"]["name"]; 
 move_uploaded_file($filename, $destination); //save uploaded picture to directory

    $_SESSION['photo'] = $destination;

For sending the email I am attaching the photo like so:

$mail->addAttachment($_SESSION['photo']);

Like I said this works if the user has decided to upload file but if they do not then I get the following error:

Could not access file: uploads/

Is there a way I can get around this? I was thinking of perhaps something like an if statement for if the photo exists then attach it but I'm really not sure how I would go about doing this. Any help would be greatly appreciated

Edit: I've tried the suggestion given by droopsnoot but it is still not working so I've played about with it and tried testing it by doing the following:

if (isset($_FILES["image"]["tmp_name"])) { 
  $filename    = $_FILES["image"]["tmp_name"];
  $destination = "uploads/" . $_FILES["image"]["name"]; 
  move_uploaded_file($filename, $destination); //save uploaded picture to directory
  $_SESSION['photo'] = $destination;
} else {
unset($_SESSION['photo']);
}

if (isset($_SESSION['photo'])) { 
echo ($_SESSION['photo']);
} else {
    echo "No photo chosen";
}

If no is selected for choosing an image it still shows: uploads/ so this would suggest that unset is not working, what could be done to sort this?

Answer 1

You should always check whether or not an image has been uploaded (like you should check all other form variables) and only try to move the image, and use it as an attachment, if there is one.

You're getting that error message because the code, without an image name, is referring to the entire directory, which you can't use in the same way. You should only set the session variable (or however you refer to the image file) if one is uploaded, and only add it as an attachment if it's present.

So

if (isset($_FILES["image"]["tmp_name"} { 
  $filename    = $_FILES["image"]["tmp_name"];
  $destination = "uploads/" . $_FILES["image"]["name"]; 
  move_uploaded_file($filename, $destination); //save uploaded picture to directory
  $_SESSION['photo'] = $destination;
} else {
unset($_SESSION['photo']);
}

and

if (isset($_SESSION['photo'])) { 
  $mail->addAttachment($_SESSION['photo']);
}

Answer 2

use

if (isset($_SESSION['photo']) && file_exists($_SESSION['photo'])) {
    $mail->addAttachment($_SESSION['photo']);
}

Answer 3

So after doing some more research into this I found that a number of people have had issues with using isset when determining whether an image has been uploaded or not. Seems that it still thinks that it is set even when null so a solution that I found that now works for me is as follows:

For finding out if a photo has been uploaded or not:

if (!file_exists($_FILES['image']['tmp_name']) || !is_uploaded_file($_FILES['image']['tmp_name'])) {
    unset($_SESSION['photo']);

}else{
  $filename    = $_FILES["image"]["tmp_name"];
  $destination = "uploads/" . $_FILES["image"]["name"]; 
  move_uploaded_file($filename, $destination); //save uploaded picture to directory
  $_SESSION['photo'] = $destination;

}

and then in the mail part for uploading I have kept it the same as to the solution droopsnoot kindly provided:

if (isset($_SESSION['photo'])) { 
  $mail->addAttachment($_SESSION['photo']);
}