Android：在customView中覆盖onClick时，OnClick无法正常工作

Question

I have created a custom view. My custom view extended from RelativeLayout :

public class CircleProgressButton extends RelativeLayout {...

In my Custom view i have a button :

private void initView(Context context, AttributeSet attrs) {
    TypedArray typedArray = context.getTheme().obtainStyledAttributes(
            attrs, R.styleable.ProgressButton, 0, 0
    );
    try {
        progressHeight = typedArray.getInt(R.styleable.ProgressButton_progress_height, progressHeight);
        progressWidth = typedArray.getInt(R.styleable.ProgressButton_progress_width, progressWidth);
        progressIconSuccess = typedArray.getResourceId(R.styleable.ProgressButton_progress_iconSuccess, R.drawable.ic_done);
        progressIconFail = typedArray.getResourceId(R.styleable.ProgressButton_progress_iconfail, R.drawable.ic_fail);
        progressText = typedArray.getString(R.styleable.ProgressButton_progress_text);
        progressBackgroundImage = typedArray.getDrawable(R.styleable.ProgressButton_progress_button_background);
    } finally {
        typedArray.recycle();
    }

    initButton();
    initProgressBar();
    initImageView();
}
    private void initButton() {
        button = new AppCompatButton(getContext());
        LayoutParams button_params = new LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT);
        button_params.addRule(RelativeLayout.CENTER_IN_PARENT, RelativeLayout.TRUE);
        button.setLayoutParams(button_params);
        button.setText(TextUtils.isEmpty(progressText) ? "Button" : progressText);
        button.setGravity(Gravity.CENTER);
        StateListDrawable background = new StateListDrawable();
        background.addState(StateSet.WILD_CARD, progressBackgroundImage);
//        background.addState(new int[]{android.R.attr.state_pressed}, progressBackgroundImagePressed);
        button.setBackground(background);
        button.setClickable(false);
/*        button.setOnClickListener(v -> {
            if (imageView.getVisibility() == VISIBLE) imageView.setVisibility(GONE);
            progressBar.setVisibility(VISIBLE);
        });*/
        addView(button);
    }

Now i attached my custom view to fragment layout :

<com.tazik.circleprogressbutton.CircleProgressButton
    android:id="@+id/btn_save"
    android:layout_width="150dp"
    android:layout_height="70dp"
    app:progress_height="30"
    app:progress_width="30"
    app:progress_text = "@string/save_btn"
    app:progress_iconfail="@drawable/ic_fail"
    app:progress_iconSuccess="@drawable/ic_done"
    app:progress_button_background="@drawable/mybutton"
    android:clickable="true"/>

In my fragment i bind fragment layout like this:

binding = DataBindingUtil.inflate(inflater, R.layout.fragment_marhaleh, container, false);
    binding.btnSave.setOnClickListener(v->{
        Log.i("======", "onSaveClicked: ");
        // do my stuff
    });

After running application and clicked on btnSave log is appearing on logcat.

Now i want to override OnClick in my custom view so in order, in my custom view i implemented View.OnClickListener :

public class CircleProgressButton extends RelativeLayout implements View.OnClickListener {
private OnClickListener listener;

@Override
public void setOnClickListener(@Nullable View.OnClickListener l) {
    listener = l;
}

And i override onClick:

@Override
public void onClick(View v) {
    if(listener != null){
        if (imageView.getVisibility() == VISIBLE) imageView.setVisibility(GONE);
        progressBar.setVisibility(VISIBLE);
   }

}

Now after running app when i clicked on btnSave log is not appearing that's mean

 binding.btnSave.setOnClickListener(v->{
    Log.i("======", "onSaveClicked: ");
    // do my stuff
});

not working? What is happening?

Answer 1

Try this worked for me, in class CircleProgressButton add this funtion:

private void init(){
    setOnClickListener(this);
}

and call init() on all constructors. remove this one

@Override
public void setOnClickListener(@Nullable View.OnClickListener l) {
 listener = l;
}

edit this method like this:

@Override
public void onClick(View v) {
    if (imageView.getVisibility() == VISIBLE) imageView.setVisibility(GONE);
    progressBar.setVisibility(VISIBLE);
}

trigger button onclick

binding.btnSave.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            binding.btnSave.onClick(v);
            Log.i("======", "onSaveClicked: ");
            //code
        }
    });

after this should be work

Answer 2

if you use databinding try this one

<com.tazik.circleprogressbutton.CircleProgressButton
 android:onClick="@{()->viewModel.click()}"
 .........../>