Javascript 功能无法启动，我不知道如何解决？

Question

I'm writing my first Javascript function where user can type in text with Prompt, user says which words in the text they would like to replace with prompt and eventually the new text gets shown in html.

The function doesn't start though (eg there's not even a prompt popping up. I'm sure it's a huge beginner mistake but I just cant figure it out. Hope someone can help me out here!

 function wordReplacer() { function originalTextPrompt() { var originalText = prompt("Write your text here") function wordToBeReplacedPrompt() { var wordToBeReplaced = prompt("Type the word to be replaced") function newWordPrompt() { var newWord = prompt("With what word would you like the previous word to be replaced?") var txt = originalText; txt = txt.replace (wordToBeReplaced, newWord); document.getElementById('wordreplacerid').innerHTML = txt; }

 <button type="button" onclick="wordReplacer()"> Click here to convert text </button> <p id="wordreplacerid"></p>

I expected a prompt to start, but it seems like the function doesn't run.

Answer 1

Please try the following code. You dont need so many functions for achieve your desired behavior

function wordReplacer() {
    var originalText = prompt("Write your text here")

    var wordToBeReplaced = prompt("Type the word to be replaced")


    var newWord = prompt("With what word would you like the previous word to be replaced ? ")   
    var txt = originalText; 
    txt = txt.replace(wordToBeReplaced, newWord); 
    document.getElementById('wordreplacerid').innerHTML = txt;
}

Answer 2

function wordReplacer() {
  function originalTextPrompt() {
    var originalText = prompt("Write your text here")
    function wordToBeReplacedPrompt() {
      var wordToBeReplaced = prompt("Type the word to be replaced")
      function newWordPrompt() {
        var newWord = prompt("With what word would you like the previous word to be replaced?") 
        var txt = originalText;
        txt = txt.replace (wordToBeReplaced, newWord);
        document.getElementById('wordreplacerid').innerHTML = txt;
      }
    }
  }
} //Adding theses

I think you can spend some time on a better tooling. Take 5 min to check theses:

• https://code.visualstudio.com/
• https://prettier.io/
• https://quokkajs.com/

Answer 3

You declare two sub-functions but do not close the braces or call them. Better:

 function wordReplacer() { var originalText = prompt("Write your text here"); var wordToBeReplaced = prompt("Type the word to be replaced"); var newWord = prompt("With what word would you like the previous word to be replaced?"); var txt = originalText; txt = txt.replace (wordToBeReplaced, newWord); document.getElementById('wordreplacerid').innerHTML = txt; }

 <button type="button" onclick="wordReplacer()"> Click here to convert text </button> <p id="wordreplacerid"></p>

Answer 4

You are only calling wordReplacer() but inside this function, there is a hierarchy of functions.

Inside wordReplacer() there is originalTextPrompt() which is not called that's why you are not getting any output.

You are performing too many hierarchy of functions which is not needed.

Try below code.

function wordReplacer() {
    var originalText = prompt("Write your text here");
    var wordToBeReplaced = prompt("Type the word to be replaced");
    var newWord = prompt("With what word would you like the previous word to be replaced ? ");
    var txt = originalText; 
    txt = txt.replace(wordToBeReplaced, newWord); 
    document.getElementById('wordreplacerid').innerHTML = txt;
}

Answer 5

This is a second answer showing how to use functions.

 function wordReplacer() { function originalTextPrompt() { return prompt("Write your text here"); } function wordToBeReplacedPrompt() { return prompt("Type the word to be replaced"); } function newWordPrompt() { return prompt("With what word would you like the previous word to be replaced?"); } var originalText = originalTextPrompt(); var wordToBeReplaced = wordToBeReplacedPrompt(); var newWord = newWordPrompt(); var txt = originalText; txt = txt.replace (wordToBeReplaced, newWord); document.getElementById('wordreplacerid').innerHTML = txt; }

 <button type="button" onclick="wordReplacer()"> Click here to convert text </button> <p id="wordreplacerid"></p>

Answer 6

function wordReplacer() {
  function originalTextPrompt() {
    var originalText = prompt("Write your text here");
    function wordToBeReplacedPrompt() {
      var wordToBeReplaced = prompt("Type the word to be replaced");
      function newWordPrompt() {
        var newWord = prompt(
          "With what word would you like the previous word to be replaced?"
        );
        var txt = originalText;
        txt = txt.replace(wordToBeReplaced, newWord);
        document.getElementById("wordreplacerid").innerHTML = txt;
      }
    }
  }
}