我需要帮助完成我的代码。 注意我是 Python 的初学者

Question

I am trying to develop a script which sends an email about checking ping regularly at one hour interval of time. I am using Python to program this script and I cannot create a log file to keep the ping logs which I need to mail. I'm new to using subprocess module and its functions.

import threading
import os

def check_ping():
    threading.Timer(5.0, check_ping).start()
    hostname = "www.google.com"
    response = os.system("ping -c 4 " + hostname)

'''
def trace_route():
    threading.Timer(5.0, trace_route).start()
    hostname = "www.google.com"
    response = os.system("traceroute" + hostname)
'''
check_ping()
#trace_route()

output = check_ping()
file = open("sample.txt","a")
file.write(output)
file.close()




import os, platform
import threading

def check_ping():
    threading.Timer(10.0,check_ping).start()
    hostname = "www.google.com"
    response = os.system("ping " + ("-n 1 " if  platform.system().lower()=="windows" else "-c 1 ") + hostname)
    # and then check the response...
    if response == 0:
        pingstatus = "Network Active"
    else:
        pingstatus = "Network Error"

    return pingstatus

pingstatus = check_ping()

Answer 1

This is what I came up with:

• using subprocess instead of os.system
• added timeout of 8 seconds
• writing to csv file instead of txt file
• added timestamps to csv file, without which I don't really see the point of logging in the first place

import os
import threading
import time
from subprocess import Popen, PIPE

def check_ping():
    threading.Timer(10.0,check_ping).start()

    # Get current time
    timestamp = int(time.time())

    # Build the command
    hostname = "www.google.com"
    if os.name == 'nt':
        command = ['ping', '-n', '1', hostname]
    else:
        command = ['ping', '-c', '1', hostname]

    # Create process
    pingProcess = Popen(command, stdout=PIPE, stderr=PIPE)
    try:
        # Timeout 8 seconds, to avoid overlap with the next ping command
        outs, errs = pingProcess.communicate(timeout=8)
    except TimeoutExpired:
        # If timed out, kill
        pingProcess.kill()
        outs, errs = pingProcess.communicate()

    # Get the return code of the process
    response = pingProcess.returncode

    # and then check the response...
    # These four lines can be removed, they are just to see if the system
    # works.
    if response == 0:
        print("Network Active")
    else:
        print("Network Error")

    # You most likely want a CSV file, as most programs accept this file type,
    # including Microsoft Excel and LibreOffice Calc
    # Further, I'm sure you want timestamps with the results.
    file = open("ping.csv","a")
    file.write(str(timestamp) + "," + str(response) + "\n")
    file.close()

check_ping()

---

Here is another version without using the system's ping command, but instead using a python library for pinging. This ensures that the code works on all operating systems:

import threading
import time

from ping3 import ping

def check_ping():
    threading.Timer(10.0,check_ping).start()

    # Get current time
    timestamp = int(time.time())

    # Build the command
    hostname = "www.google.com"

    # Run ping
    ping_result = ping(hostname, timeout=8)
    ping_success = False if ping_result is None else True

    # and then check the response...
    # These four lines can be removed, they are just to see if the system
    # works.
    if ping_success:
        print("Network Active (" + str(ping_result) + ")")
    else:
        print("Network Error")

    # You most likely want a CSV file, as most programs accept this file type,
    # including Microsoft Excel and LibreOffice Calc
    # Further, I'm sure you want timestamps with the results.
    file = open("ping.csv", "a")
    ping_value_str = str(ping_result) if ping_success else "NaN"
    file.write(str(timestamp) + "," + ("0" if ping_success else "1") + "," + ping_value_str + "\n")
    file.close()

check_ping()