在部署 Firebase 云 Function 时收到“每个都应该返回值或抛出”错误

Question

I am new to Cloud Functions so I having issues with below code, the error is in the last part where the console.log is mentioned, please assist what shall I been done to deploy the Function successfully, as I am following a tutorial there is no such error for the name.

'use-strict'

const functions = require('firebase-functions');
const admin = require("firebase-admin");

admin.initializeApp(functions.config().firebase);
exports.sendNotifications = functions.firestore.document("users/{user_id}/notifications/{notification_id}").onWrite(event => {


    const user_id = event.params.user_id;
    const notification_id = event.params.notification_id;




    return admin.firestore().collection("users").doc(user_id).collection("notifications").doc(notification_id).get().then(queryResult => {

        const from_user_id = queryResult.data().from;
        const message =  queryResult.data().message;

        const from_data = admin.firestore().collection("users").doc(from_user_id).get();
        const to_data = admin.firestore().collection("user").doc(user_id).get();

        return Promise.all([from_data, to_data]).then(result => {
            const from_name = result[0].data().name;
            const to_name = result[1].data().name;
            const token_id  = result[1].data().token_id;

            const payload  = {
                notification: {
                    title: "Notification from:" + from_name,
                    body: message,
                    icon: "default"


                }
            };

            return admin.messaging().sendToDevice(token_id, payload).then(result =>{

                console.log("notifcation sent");
            });

        });

    });




});

Answer 1

By chaining your Promises and returning null in the last then() , as follows, you should solve your problem:

exports.sendNotifications = functions.firestore.document("users/{user_id}/notifications/{notification_id}").onWrite(event => {

    const user_id = event.params.user_id;
    const notification_id = event.params.notification_id;

    return admin.firestore().collection("users").doc(user_id).collection("notifications").doc(notification_id).get()
        .then(queryResult => {

            const from_user_id = queryResult.data().from;
            const message = queryResult.data().message;

            const from_data = admin.firestore().collection("users").doc(from_user_id).get();
            const to_data = admin.firestore().collection("user").doc(user_id).get();

            return Promise.all([from_data, to_data]);
        })
        .then(result => {
            const from_name = result[0].data().name;
            const to_name = result[1].data().name;
            const token_id = result[1].data().token_id;

            const payload = {
                notification: {
                    title: "Notification from:" + from_name,
                    body: message,
                    icon: "default"

                }
            };

            return admin.messaging().sendToDevice(token_id, payload)

        })
        .then(messagingResponse => {
            console.log("notification sent");
            return null;   //Note the return null here, watch the 3 videos about "JavaScript Promises" from the Firebase video series: https://firebase.google.com/docs/functions/video-series/
        });

});

You may have a look at the corresponding MDN documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises#Chaining

Also, note that, in your code, it seems that you are not using the to_name constant.