从centOS7上的文本文件添加用户的脚本出现问题

Question

I'm setting up a server and adding users and was self teaching how to add a batch of test users with no passwords. So I have a file with first and last names in username.txt like:

james bond 
bobby dennis
alex newell
jon temple
joshua bridal
paul spears

I try to run this script and it says unexpected error in line 8.

#!/bin/bash
while user in 'cat userlist.txt'
do
  USER_LIST="$(cut -d " " -f 1,2,3 userlist.txt --output delimiter='.')"
  echo "$USER_LIST" | while read user;
  do useradd "$user"
done

The outcome I'd like is username :james.bond . That'ss the format I'm looking for. If I can get that to work then I can add a random number generator at the end.

I am a very weak scripter so most of this stuff i have found online and am trying to piece it together.

Any help would be great.

Answer 1

First, let's create a sample for your userlist.txt , using a FIRSTNAME LASTNAME format:

cat<<EOF > /tmp/userlist.txt
james bond
sherlock holmes
hercule poirot
name surname
another one
the sixth
seven dwarfs
finally eight
EOF

now, you can make a simpler loop than the original:

cat /tmp/userlist.txt | while read firstname lastname ; do 
   echo useradd -m "${firstname}.${lastname}" ; 
done

the output is going to be:

useradd -m james.bond
useradd -m sherlock.holmes
useradd -m hercule.poirot
useradd -m name.surname
useradd -m another.one
useradd -m the.sixth
useradd -m seven.dwarfs
useradd -m finally.eight

when you find out that you are satisfied with the result, just remove the echo used for debugging:

#!/bin/bash
cat /tmp/userlist.txt | while read firstname lastname ; do 
  useradd -m "${firstname}.${lastname}" ; 
done

the read builtin command expects strings separated by spaces.