这个while循环导致我的程序挂起

Question

I have a function that is causing my program to hang. I have commented out the function and everything else runs just fine. The program gets to where the loop should end and it just waits for input. The isBomb() function is simply a getter and returns a true/false value. The function is part of a Minesweeper game. I am trying to figure out a way to figure out how many bombs are adjacent to the chosen cell. I could post the whole program, but it is around 250-350 lines. The makeNum method is a simple getter that sets the cell number equal to the value of the parameter.

void mazeDisplay::countBombAdj(int row, int col) {
    int counter = 0;
/*  for (int x = row - 1; x < row + 1; x++) {
        while ((x > - 1) && (x < 4)) {
            for (int y = col - 1; y < col + 1; y++) {
                while ((-1 < y) && (y < 4)) {
                    if (mazeCells[x][y].isBomb() == true)
                        counter += 1;
                }
            }
        }
    }*/

    mazeCells[row][col].makeNum(counter);
}

Answer 1

It's your line:

while ((x > - 1) && (x < 4))

x dosn't change and there aren't any break 's in that loop so the loop is infinite.

Similarly for:

while ((-1 < y) && (y < 4)) 

It looks like, as others have commented, that you what if statements, not (infinite) while loops:

void mazeDisplay::countBombAdj(int row, int col) {
    int counter = 0;
    for (int x = row - 1; x < row + 1; x++) {
        if ((x > - 1) && (x < 4)) {
            for (int y = col - 1; y < col + 1; y++) {
                if ((-1 < y) && (y < 4)) {
                    if (mazeCells[x][y].isBomb() == true)
                        counter += 1;
                }
            }
        }
    }

    mazeCells[row][col].makeNum(counter);
}

Answer 2

Once you've entered one of your while-loops, the condition will never become false and you're stuck in it forever.

Also, checking those conditions with if instead would lead you to only scan a three-by-three square, which is a very boring minesweeper game.
You need to check if you're inside the board, not within that small square.

I would loop over the appropriate range instead of skipping invalid cells:

for (int x = std::max(0, row-1); x < std::min(number_of_rows, row+2); x++)
{
    for (int y = std::max(0, col-1); y < std::min(number_of_cols, col+2); y++)
    {
        if (mazeCells[x][y].isBomb())
            counter += 1;
    }
}