如何修复 - 从 'char *' 分配给 'char' 使得 integer 从没有强制转换的指针

Question

I need to remove all the commas from my user input. The code is working but it's giving the warning "assignment to 'char' from 'char *' makes integer from pointer without a cast". I need to get rid of this warning.

removeCommas(argv[1]);

printf("%s", argv[1]);

return 0;



    for(i=0; i<strlen(num); i++)
    {   
        c = *(num + i);
        if(c == 44)    
        {   
            *(num + i) = "";                                               
        }                        
    }       

return 0;

Answer 1

        *(num + i) = "";                                               

I'm not sure what you are trying to assign here, but double quotes ( "" ) denotes char * .

If you wanted to remove , (ASCII 44) from the string it is not the way to do it. You need to shift all the chars after , until \0 and terminate the string properly.

Answer 2

You should work on a char by char basis. loop over your input string, search for the comma, and then override it with the remaining of the string:

#include "string.h"
#include "stdio.h"



int main()

{
    char num[100];
    strcpy(num, "abc,def,,a,");

    unsigned int i;
    char c;

    for (i = 0; i < strlen(num); i++)
    {
        c = num[i];
        if (c == ',')
        {
            if (num[i + 1] == '\0')
                num[i] = '\0';
            else
            {               
                size_t s = strlen(num + i + 1);
                memmove(num + i, num + i + 1, s+1);

                --i;
            }
        }
    }

    printf("%s", num);

    return 0;
}

Answer 3

Note that (if you are going to remove all comas from string), the resulting string may be shorter than source one. And there is no real "string" type in C - it's only array of chars.

I think, that proper way will be:

1. Count number of commas in source string
2. Calculate length of resulting string and reserve enough memory for it
3. Iterate throug characters of source string, and copy them to resulting string, if they are not commas