如何使用数组进行优化？

Question

I'm starting to learn about google app script with JavaScript. I wrote this code, but it is really slow and executing the function takes too long. I think this isn't the best way to do the function. Is there any option/way (array), to make it faster or in other way to reduce to the time waiting? All I wish to do is to insert "today's date", when a column cell value is set true, in another cell column.

function onEdit() {
  sConfDate();
}

function sConfDate(){
  var ss = SpreadsheetApp.getActiveSpreadsheet();
  var dataSheet = ss.getSheetByName("Data");
  var dataRange = dataSheet.getRange(9, 1, dataSheet.getLastRow(), 43);
  var data = dataRange.getValues();
  var d = new Date();
  var dd = d.getDate();
  var mm = d.getMonth() +1;
  var yyyy = d.getFullYear();
  var date = dd + "/" + mm + "/" + yyyy;
  var needSay = 'SUC';
  var needSay2 = '-';

  for(var i = 0; i < data.length; i++){
    //row items
    var values = data[i];
    //column items
  for(var j = 0; j < values.length; j++){
    var row = values[j];
    var checkRow = row;
    //Logger.log(checkRow);
       if(checkRow === needSay && checkRow === needSay2){
         dataSheet.getRange(9 + i, 43).setValue(date);
      };
    };
  };
}

Answer 1

Perhaps this is what you had in mind:

function sConfDate(){
  var ss=SpreadsheetApp.getActive();
  var dataSheet=ss.getSheetByName("Data");
  var dataRange=dataSheet.getRange(9, 1, dataSheet.getLastRow()-8, 43);
  var data=dataRange.getValues();
  var datacol43=dataSheet.getRange(9,43,dataSheet.getLastRow()-8,1).getValues();
  var date=Utilities.formatDate(new Date(), Session.getScriptTimeZone(), "dd/MM/yyyy");
  data.forEach(function(r,i){
    r.forEach(function(c,j){
      if(c=='SUC' || c=='-') {
        datacol43[i][0]=date;
      }
    });
  });
  dataSheet.getRange(9,43,dataSheet.getLastRow()-8,1).setValues(datacol43);                   
}

This might actually run faster:

function sConfDate(){
  var ss=SpreadsheetApp.getActive();
  var sh=ss.getSheetByName("Data");
  var rg=sh.getRange(9, 1, sh.getLastRow()-8, 43);
  var data=rg.getValues();
  var crg=sh.getRange(9,43,sh.getLastRow()-8,1);
  var cdata=crg.getValues();
  var date=Utilities.formatDate(new Date(), Session.getScriptTimeZone(), "dd/MM/yyyy");
  for(var i=0;i<data.length;i++) {
    for(var j=0;j<data[i].length;j++) {
      if(data[i][j]=='SUC' || data[i][j]=='-') {
        cdata[i][0]=date;
        break;
      }
    }
  }
  crg.setValues(cdata);                   
}

Perhaps this would be better.

function sConfDate2(){
  var ss=SpreadsheetApp.getActive();
  var sh=ss.getSheetByName("Data");
  var rg=sh.getRange(9, 1, sh.getLastRow()-8, 8);
  var data=rg.getValues();
  var crg=sh.getRange(9,8,sh.getLastRow()-8,1);
  var cdata=crg.getValues();
  var date=Utilities.formatDate(new Date(), Session.getScriptTimeZone(), "dd/MM/yyyy");
  for(var i=0;i<data.length;i++) {
    var row=data[i];//Im guessing this is probably what you want unless you have particular columns in mind
    if(row.indexOf('SUC')!=-1 && row.indexOf('-')!=-1) {
      cdata[i][0]=date;
    }
  }
  crg.setValues(cdata);                   
}

Answer 2

Spreasheet picture

The frist column ("SUC CONFIRMADA") is an state that changes every day itself. The second column is the next one form the first one in the picture. All I want to do is get those values from this columns in array. Then make an statement like this : If (the first cell = "SUC CONFIRMADA" and second cell = "-") = insert today's date. This is why I need two statments, because i have inserted a dates in the second column and i won't delete them.