Node JS/Express 路由

Question

I need a little guidance with routing in my Node/Express app. Initially, I create a new business from the Business model (works fine). After creating the business, I want a separate route which adds the current FX rates offered by that business (these fields will then be updated daily). My business model looks like this (simplified for purpose of example):

let businessSchema = new mongoose.Schema({
   name: String,
   category: String,
   longDescription: String,
   images: [ {url: String, public_id: String} ],

   usdHkd: { type: String, default: "" },
   hkdUsd: { type: String, default: "" },
   rateCreatedAt: {
      type:Date,
      default:Date.now
   },
});

When the business is first created, only the name, category, longDesc and images are populated, with default values for the FX rate fields. That works fine using these routes:

/* GET business new /business/new */
router.get("/new", isLoggedIn, asyncErrorHandler(businessNew));

/* POST business create /business */
router.post('/', isLoggedIn, upload.fields([{ name: 'images', maxCount: 10 }]), asyncErrorHandler(businessCreate));

I then set up separate routes/controllers like this for subsequently adding the FX rates, but I don't think these are correctly defined:

/* GET business index /business */
router.get('/:id/remittance/new', asyncErrorHandler(remittanceNew));

/* GET business index /business */
router.put('/:id/remittance', asyncErrorHandler(remittanceCreate));

    //Remittances New
    async remittanceNew (req, res, next) {
        let business = await Business.findById(req.params.id);
        res.render('remittanceViews/newRemittance', { business }); 
    },

    //Business Update
    async remittanceCreate (req, res, next) {

        let business = await Business.findByIdAndUpdate(req.params.id, req.body.business);
        console.log(business);

        //update the post with any new properties
        business.usdHkd = req.body.business.usdHkd;
        business.hkdUsd = req.body.business.hkdUsd;
        business.rateCreatedAt = req.body.business.rateCreatedAt;

        //save the updated post in the db
        business.save();
        //redirect to show page
        res.redirect(`/business/${business.id}`);
    },

The error message I get when I try to update is:

Cannot read property 'usdHkd' of undefined

Can anyone please advise where I'm going wrong here? Thanks

Answer 1

The error message indicates that usdHkd 's parent variable in undefined . Most probably, this error is coming from business.usdHkd in business.usdHkd = req.body.business.usdHkd; (you can confirm it by adding more console.log() lines around this line and checking the outputs).

If business.usdHkd = req.body.business.usdHkd; is giving error, that means, business is undefined . However, you don't need this line as business is already updated by findByIdAndUpdate .

READ: Model.findByIdAndUpdate() and Promises in Mongoose

//Business Update
async remittanceCreate (req, res, next) {

    let business = await Business.findByIdAndUpdate(req.params.id, req.body.business);
    console.log(business);

    // Below code is not required since findByIdAndUpdate() will update your model
    /*
    //update the post with any new properties
    business.usdHkd = req.body.business.usdHkd;
    business.hkdUsd = req.body.business.hkdUsd;
    business.rateCreatedAt = req.body.business.rateCreatedAt;

    //save the updated post in the db
    business.save();
    */

    //redirect to show page
    res.redirect(`/business/${business.id}`);
},

UPDATE

You told that business is defined, but it's not getting updated. The reason is findOneAndUpdate() requires new option to be set as true else findOneAndUpdate() returns the old object (before updating it -- in a sense). So, please change the first line of remittanceCreate() to:

let business = await Business.findByIdAndUpdate(req.params.id, req.body.business, {new: true});