为什么用户输入的最小数字没有添加到列表中？

Question

There was a test in school where we had to write a C# console program that reads positive integers below 100 from user input and then writes out some details like the biggest number. I used a list to store the numbers. I tested it with some random numbers I typed in but the program only adds the numbers to list starting with the second smallest one.

int count = 0;
List<int> bekertek = new List<int>();
int bekert = Convert.ToInt32(Console.ReadLine());
double atlag;
while (bekert > 0 && bekert < 100)
{
    bekert = Convert.ToInt32(Console.ReadLine());
    count++;
    bekertek.Add(bekert);
}
/* This section is only for checking the list's elements
foreach (var i in bekertek)
    {
    Console.Write(i + " ");
}*/
Console.WriteLine("A bevitt adatok száma: {0}", count);
bekertek.Sort();
bekertek.Remove(bekertek.Last());
atlag = bekertek.Average();
Console.WriteLine("A legnagyobb érték: {0}", bekertek.Last());
Console.WriteLine("A legkisebb érték: {0}", bekertek.First());
Console.WriteLine("Az adatok átlaga: {0}", atlag);

What did I do wrong?

Answer 1

For input in console, I think the do...while loop is the ideal construct. Menus or requesting a number - it covers all of those.

As for what went wrong: Actually it adds all numbers to the collection (that debug code should confirm it). You just remove the smalest number from the collection between Sorting and Display:

bekertek.Sort();
bekertek.Remove(bekertek.Last());  //Should not have done this.
atlag = bekertek.Average();

There is a saying: "The 2 most common issues in Progamming is naming variables, chache invalidation and off-by-one errors." But this specific to make is somewhat unique :)

Edit: As Biesi Grr pointed out, you also ignore the first input:

int bekert = Convert.ToInt32(Console.ReadLine()); //this is never processed
double atlag;
while (bekert > 0 && bekert < 100)
{
    bekert = Convert.ToInt32(Console.ReadLine());
    count++;
    bekertek.Add(bekert);
}

Maybe you wanted to use a ReadKey() here? There is also no need for a counter - that is actually the job of List.Lenght. In any case, a do..while would make that line unessesary any way.

let us make a fixed, do...while version

bool repeat= true;
do{
  int bekert = Convert.ToInt32(Console.ReadLine());
  if(bekert > 0 && bekert < 100)
    bekertek.Add(bekert);
  else
    repeat = false;
}while(repeat )