“git push origin master”在 bash 脚本中给出了奇怪的行为

Question

I have this simple function in my bashrc file

function aupgrade {
    cat ~/.bash_aliases > ~/bash/.bash_aliases
    cd ~/bash
    git add .

    if [[ $1 == "" ]]; then
        git commit -m "Update"
    else
        git commit -m "$1"
    fi

    git push origin master

    cd - 1>/dev/null
}

This function has a purpose, this is the expected behavior:

First , replace the content of the .bash_aliases file in the bash repository with the stdout of cat ~/.bash_aliases

Second , go into the ~/bash directory which is a git respository

Third , stage all changes

Fourth , if when calling the aupgrade function the following argument is nothing, just commit with the "Update" message, but if the user wrote an argument, like aupgrade "New commit!" , commit the changes with such argument as the message, git commit -m $1

Fifth , push the changes

Sixth , go back to the previous directory

BUT, it doesnt do that, instead it just does:

First , replace the content of the .bash_aliases file in the bash repository with the stdout of cat ~/.bash_aliases

Second , go into the ~/bash directory which is a git respository

Third , stage all changes

Fourth , commit with the "Update" message although there is an argument

Fifth , push the changes

Sixth , go back to the previous directory

This is weird. This looks product of the git push origin master line. It's not a conditional problem, because when I wrote another function like this but without the git push origin master line it worked as desired.

Why does this happen? Is there any solution?

This is what set -x shows to me, it's really weird

Answer 1

So I have tested your code, and the only problem I could find is that passing your first argument as a string with multiple exclamation marks inserts the same (or previous?) command unless you escape it:

It looks like this is exactly what happened for you, but you had "set -x" ran beforehand, thus it replaced the double exclamation marks with that command.

I'd also recommend storing function arguments in named local variables for cleaner code.