等待 foreach 任务完成以继续

Question

Hey i want to my bot send a message when the foreach is finished with the duration

code:

        let beforecheck = new Date();


        bot.guilds.forEach(guild => {

            //my foreach code

            }).then(() => {

            let aftercheck = new Date();

            var finished = new Discord.RichEmbed()
            .setDescription("✔ Finished ✔")
            .addField("🏓 Bot Latency", bot.ping + " ms")
            .addField("expected time", expectedtime + " minute(s)")
            .addField("final time", (60000 / (beforecheck - aftercheck)) + " minute(s)")

            message.channel.send(finished)

            })

thanks for any response

Answer 1

From your code it seems like you expect the forEach to take a significant amount of time, and from the fact that you're iterating over guild s I expect that involves some sort of asynchronous Discord API calls. If those are both true, forEach is the wrong tool for the job.

If order matters : (in an async function )

    let beforecheck = new Date();

    for(const guild of bot.guilds) { //might need bot.guilds.array()
        //use await on asynchronous calls
    }

    let aftercheck = new Date();

    var finished = new Discord.RichEmbed()
        .setDescription("✔ Finished ✔")
        .addField("🏓 Bot Latency", bot.ping + " ms")
        .addField("expected time", expectedtime + " minute(s)")
        .addField("final time", (60000 / (beforecheck - aftercheck)) + " minute(s)")

    message.channel.send(finished)

If order doesn't matter :

    let beforecheck = new Date();

    await Promise.all(bot.guilds.map(guild => {
        //return a promise or use async/await here
    }); //can also use .then() here but async/await is better

    let aftercheck = new Date();

    var finished = new Discord.RichEmbed()
        .setDescription("✔ Finished ✔")
        .addField("🏓 Bot Latency", bot.ping + " ms")
        .addField("expected time", expectedtime + " minute(s)")
        .addField("final time", (60000 / (beforecheck - aftercheck)) + " minute(s)")

    message.channel.send(finished)