在多个对象上调用相同的方法

Question

I have a number of methods that are called on different 3rd party systems. I now have another 3rd party system that will have the same set of methods actioned against it. If both 3rd party systems are connected I will then call the methods on each object in turn.

Currently I have a class that I pass round that I can call the method once and it checks and then calls it on each system that is enabled, this has an instance of each objects classes, similar to this:

 public class AACSCaller 
    {

        3rdPartySystem1 _system1;
        3rdPartySystem2 _system2;

        public AACSCaller(Settings appSettings)
        {
            _appSettings = appSettings;
            if (appSettings.system1Enabled)
            {
                _system1 = new 3rdPartySystem1();
            }
            if (appSettings.system2Enabled)
            {
                _system2 = new 3rdPartySystem2();
            }
        }
        public void Method1()
        {
            if (appSettings.system1Enabled)
            {
                _system1.Method1();

            }
            if (appSettings.system2Enabled)
            {
                _system2.Method1();

            }
        }

        public void Method2()
        {
            if (appSettings.system1Enabled)
            {
                _system1.Method2();

            }
            if (appSettings.system2Enabled)
            {
                _system2.Method2();

            }
        }
    }

Is this sensible, as it does seem there maybe a better way and I may well be connecting additional system at some point.

Answer 1

A possible solution here is to define an interface or base class for 3rdPartySystem1 and 3rdPartySystem2 classes, store instances in a collection and call required methods for every item in collection. If only one system is enabled, you'll have only one item in collection, if both is enabled, you'll call them one by one in loop

public interface IThirdPartySystem
{
    void Method1();
    void Method2();
}

public class ThirdPartySystem1 : IThirdPartySystem
{
    //implementation
}

public class ThirdPartySystem2 : IThirdPartySystem
{
    //implementation
}

public class AACSCaller 
{
    IList<IThirdPartySystem> _systems = new List<IThirdPartySystem>();

    public AACSCaller(Settings appSettings)
    {
        _appSettings = appSettings;
        if (appSettings.system1Enabled)
        {
            _systems.Add(new ThirdPartySystem1());
        }
        if (appSettings.system2Enabled)
        {
            _systems.Add(new ThirdPartySystem2());
        }
    }
    public void Method1()
    {
        foreach (var system in _systems)
            system.Method1();           
    }

    public void Method2()
    {
         foreach (var system in _systems)
            system.Method2();            
    }
}

Answer 2

I suggest you to use interface that have Method1 and Method2 methods and then create to classes System1 and System2 that are implements the interface. Where AACSCaller is create you initialize the correct implementation of the interface and in your methods your just Call to the correct instance method without conditions.

public class AACSCaller 
{
    IThirdPartySystem ThirdPartySystem;

    public AACSCaller(Settings appSettings)
    {
        _appSettings = appSettings;
        ThirdPartySystem = appSettings.system1Enabled ? new ThirdPartySystem1() : new ThirdPartySystem2();

    }

    public void Method1() => ThirdPartySystem.Method1();

    public void Method2() => ThirdPartySystem.Method2();
}

public interface IThirdPartySystem
{
    void Method1();
    void Method2();
}

public class ThirdPartySystem1 : IThirdPartySystem
{
    public void Method1()
    {
        //code here..
    }

    public void Method2()
    {
        //code here..
    }
}

public class ThirdPartySystem2 : IThirdPartySystem
    {
        public void Method1()
        {
            //code here..
        }

        public void Method2()
        {
            //code here..
        }
    }