构造函数的字符串输入参数上的 Java 越界异常

Question

I'm new to Java and I keep trying to debug my code to no avail. I'm trying to use arrayList to build an array for a newEmployee and append it an arraylist of employees ( ArrayList> ). The dateParse, nameParse and addressParse are separate methods being called within this array method.

Where error is:

import java.util.ArrayList;

public class NewEmployee {

   private ArrayList<ArrayList<String>> allEmployees;
   private ArrayList<String> currentEmployee;


   //Constructor
   NewEmployee(String number, String name, String address, String date) {
      //grab first field, Number
      this.currentEmployee.set(0, number);
      //grab next field, full Name and pass to nameParse as input
      NameParse nameParse = new NameParse(name);
      this.currentEmployee.set(1 , nameParse.getFirstName());
      this.currentEmployee.set(2, nameParse.getLastName());
      //call to Address Parse to separate address fields
      AddressParse addressParse = new AddressParse(address);
      this.currentEmployee.set(3, addressParse.getStreet());
      this.currentEmployee.set(4, addressParse.getCity());
      this.currentEmployee.set(5, addressParse.getStateCode());
      this.currentEmployee.set(6, addressParse.getPostalCode());
      //grab last input field, Hire Date & sent to DateParse
      DateParse dateParse = new DateParse(date);
      this.currentEmployee.set(7, dateParse.getMonth());
      this.currentEmployee.set(8, dateParse.getDay());
      this.currentEmployee.set(9, dateParse.getYear());
      //add the current employee to a row in allEmployees
      this.allEmployees.add(this.currentEmployee);
   }

   //default constructor
   NewEmployee(){
      this.currentEmployee = new ArrayList<String>();
      //this.allEmployees = new ArrayList<ArrayList<String>>();
   }

   public String[][] toArray() {
      //10 fields for each employee
      String [][] everyEmployee = new String[this.allEmployees.size()][10];
      return everyEmployee;
   }


   public String toString() {
    //create temporary string of values
      StringBuilder tempEmployee = new StringBuilder();
      for (int i=0; i<this.allEmployees.size()-1; i++) {
         //String [] empDetails = new String[allEmployees(i).size]
         for(int j = 0; j<10; j++) {
            //insert arraylist values, elementwise into string
            tempEmployee = tempEmployee.append(this.allEmployees.get(i).get(j));
         }
      }
      //return the string
      return tempEmployee.toString();
   }


   public ArrayList<ArrayList<String>> getAllEmployees() {
      return this.allEmployees;
   }

      public ArrayList<String> getCurrentEmployee() {
      return this.currentEmployee;
   }
}

From main, the variables are input correctly and sent within specifications, but I get an error at

this.currentEmployee.set(0, number);

If anyone can help understand how to make this work or why it's not working that would be amazing!

Answer 1

If this can help anyone else-- I never got this code working. I tried using .add as the comment suggested and it didn't work, still with the same error. I also tried allocating 30 at the ArrayList level as well as using ensurecapacity code.

The thing that ended up working was: I redesigned the Employee class to hold attributes, no list or array.

Then I made a separate file CurrentEmployeeArray class that held all of this information in an array.

In yet another file I put the AllEmpArrayList class that concatenated all the Current Employees together using the .add .

I don't know why none of the other solutions worked- all theoretically should've done so. However, the design is more robust when you separate all these tasks too. As I go forward I'm learning that, though from my viewpoint a lot of "simple" classes makes things more complex than putting everything into an array at once, a lot of simple classes helps a ton when it comes to debugging, compiling, and running Java programs. I don't know if this will hold true over time- but it is for now.

Employee:

/**
 * this method takes a String number, String name, String address, and String 
 * date and sends them to other methods to separate fields and 
 * creates a new employee array.  Public methods include getters, setters, and 
 * toString.
 * @author CaseyJayne
 *
 */
public class NewEmployee {
   private String employeeCode;
   private String firstName;
   private String lastName;
   private String streetAddress;
   private String city;
   private String stateCode;
   private String zipCode;
   private String hireMonth;
   private String hireDay;
   private String hireYear;
   private String [] currentEmployee = new String [10];


   //Constructor
   NewEmployee(String number, String name, String address, String date) {
      setEmployeeCode(number);
      NameParse nameParse = new NameParse(name);
      setFirstName(nameParse.getFirstName());
      setLastName(nameParse.getLastName());
      AddressParse addressParse = new AddressParse(address);
      setStreetAddress(addressParse.getStreet());
      setCity(addressParse.getCity());
      setStateCode(addressParse.getStateCode());
      setZipCode(addressParse.getPostalCode());
      DateParse dateParse = new DateParse(date);
      setHireMonth(dateParse.getMonth());
      setHireDay(dateParse.getDay());
      setHireYear(dateParse.getYear());
   }
}

ArrayList Class

class AllEmployeesArray {
   private ArrayList<String[]> allEmployeesList= new ArrayList<>();

   AllEmployeesArray(String[] inputArray){
      this.allEmployeesList.add(inputArray);
   }
   //default constructor
   AllEmployeesArray(){
      this.allEmployeesList.ensureCapacity(20);
   }

public void addEmp(String[] inputArray){
      this.allEmployeesList.add(inputArray);
   }
   public ArrayList<String[]> getAllEmployeesList() {
      return this.allEmployeesList;
   }

within main:

String[] newEmpArray= {newEmp.getEmployeeCode(), newEmp.getFirstName(), 
               newEmp.getLastName(), newEmp.getHireDay(), newEmp.getHireMonth(), 
               newEmp.getHireYear(), newEmp.getStreetAddress(), 
               newEmp.getCity(), newEmp.getStateCode(), newEmp.getZipCode()};
         allEmpArray.addEmp(newEmpArray);