如何制作高效的getter和setter方法

Question

I am trying to get largest from three integers of 5 objects, the code works, but looks kind of bulky and inefficient, is there any way I can improve it? can I also combine one method getLargest to compute largest, smallest and average, without using an array?

  class Calc
  {
    private int num1, num2, num3, Ans;

    public int ans  { get { return Ans; }  set { Ans = value; } }
    public int Num1 { get { return num1; } set { num1 = value; } }
    public int Num2 { get { return num2; } set { num2 = value; } }
    public int Num3 { get { return num3; } set { num3 = value; } }

    public void getLargest(int x, int y, int z)
    {
         ans=(Math.Max(Math.Max(x, y), z));
    } 
  }

Answer 1

Technically you can make this a lot smaller...

public class Calc
{
    public int Max => Math.Max(Math.Max(Num1, Num2), Num3);
    public int Min => Math.Min(Math.Min(Num1, Num2), Num3);
    public int Avg => (Num1 + Num2 + Num3) / 3;
    public int Num1 { get; set; }
    public int Num2 { get; set; }
    public int Num3 { get; set; }
}

(This requires using System.Linq; at the top)

What this does is creates auto-properties (properties with no bodies) which automatically creates the backing fields for you.

Technically this is a little more inefficient as it will calculate them every time, so what you would want to do is something more like this:

public class Calc
{
    public int Num1 { get; private set; }
    public int Num2 { get; private set; }
    public int Num3 { get; private set; }
    public int Max { get; private set; }
    public int Min { get; private set; }
    public int Avg { get; private set; }

    public Calc(int num1, int num2, int num3)
    {
        Num1 = num1;
        Num2 = num2;
        Num3 = num3;
        Max = Math.Max(Math.Max(Num1, Num2), Num3);
        Min = Math.Min(Math.Min(Num1, Num2), Num3);
        Avg = (Num1 + Num2 + Num3) / 3;
    }
}

(There are different ways to construct this object, the above is just an easy-to-understand method of doing so). This will "cache" the results in an immutable object (which is something you want to learn about).

Answer 2

As you've specified without using an array, I suppose this is your best option for "cleaner", though I doubt this produces any noticeable speed improvements, is there a reason you don't want to use an array? What's the purpose of the class?

class Calc
{

    public int ans { get; set; }

    public int Num1 { get; set; }

    public int Num2 { get; set; }

    public int Num3 { get; set; }

    public void getLargest(int x, int y, int z)
    {
        ans = Math.Max(Math.Max(x, y), z);
    }

}