While Not Loop 运行次数超出预期

Question

I have a problem where I am trying to make a word search puzzle generator and I have run into multiple problems throughout the day. (Thanks to this community I've solved most of them!)

I have another problem now where I have a loop that should find a spot to place a word, place it, and move on to the next word. Instead it is finding all possible spots the word can be and placing the word in all of them. I only want each word to appear once. I thought that the lines while not placed and placed = true would handle this but it isn't working.

Thanks in advance for any help, and here is my code:

import tkinter as tk
import random
import string

handle = open('dictionary.txt')
words = handle.readlines()
handle.close()

grid_size = 10

words = [ random.choice(words).upper().strip() \
            for _ in range(5) ]

print ("The words are:")
print(words)

grid = [ [ '_' for _ in range(grid_size) ] for _ in range(grid_size) ]

orientations = [ 'leftright', 'updown', 'diagonalup', 'diagonaldown' ]

class Label(tk.Label):
    def __init__(self, parent, **kwargs):
        super().__init__(parent, **kwargs, font=("Courier", 44))
        #self.bind('<Button-1>', self.on_click)

    #def on_click(self, event):
        #w = event.widget
        #row, column = w.grid_info().get('row'), w.grid_info().get('column')
        #print('coord:{}'.format((row, column)))
        #w.destroy()

class App(tk.Tk):
    def __init__(self):
        super().__init__()

        for row in range(grid_size):
            for column in range(grid_size):
                for word in words:
                    word_length = len(word)

                    placed = False
                    while not placed:
                        orientation = random.choice(orientations)

                        if orientation == 'leftright':
                            step_x = 1
                            step_y = 0
                        if orientation == 'updown':
                            step_x = 0
                            step_y = 1
                        if orientation == 'diagonalup':
                            step_x = 1
                            step_y = -1
                        if orientation == 'diagonaldown':
                            step_x = 1
                            step_y = 1

                        x_position = random.randrange(grid_size)
                        y_position = random.randrange(grid_size)

                        ending_x = x_position + word_length*step_x
                        ending_y = y_position + word_length*step_y

                        if ending_x < 0 or ending_x >= grid_size: continue
                        if ending_y < 0 or ending_y >= grid_size: continue

                        failed = False


                        for i in range(word_length):
                            character = word[i]

                            new_position_x = x_position + i*step_x
                            new_position_y = y_position + i*step_y

                            character_at_new_position = grid[new_position_x][new_position_y]
                            if character_at_new_position != '_':
                                if character_at_new_position == character:
                                    continue
                                else:
                                    failed = True
                                    break

                        if failed:
                            continue
                        else:
                            for i in range(word_length):
                                character = word[i]

                                new_position_x = x_position + i*step_x
                                new_position_y = y_position + i*step_y

                                grid[new_position_x][new_position_y] = character
                                if ( grid[row][column] == grid[new_position_x][new_position_y] ):
                                    grid[row][column] = grid[new_position_x][new_position_y]
                                    Label(self, text=character).grid(row=row, column=column)
                        placed = True
                    #if ( grid[row][column] == '_' ):
                        #txt = random.SystemRandom().choice(string.ascii_uppercase)
                        #Label(self, text=txt).grid(row=row, column=column)
if __name__ == '__main__':
    App().mainloop()

Answer 1

I can assure you that your expectation of while loop is correct.

In [1]: placed = False                                                                                                                                                                                             

In [2]: i = 0                                                                                                                                                                                                      

In [3]: while not placed: 
   ...:     i += 1 
   ...:     print(i) 
   ...:     if i == 5: 
   ...:         placed = True 
   ...:                                                                                                                                                                                                            
1
2
3
4
5

Given that, my suspicion is that your code always hit continue , which means it never hits the statement placed = True , hence infinite loop. So I suggest you check if your condition to continue is as expected.

Hope this helps!