Android数据绑定导致包含布局问题

Question

Hello hope you are all fine. I migrated my project from old version to latest version ie 29. And I resolve all the errors. The problem is that I cannot resolve my toolbar error.

<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools">

    <data>

        <variable
            name="controller"
            type="com.cvvm.Controller" />

        <variable
            name="menu"
            type="java.lang.Integer" />

        <variable
            name="itemClickListener"
            type="androidx.appcompat.widget.Toolbar.OnMenuItemClickListener" />

        <import type="com.bonnti.misc.NavigationClickListener" />
    </data>

    <androidx.appcompat.widget.Toolbar
        android:id="@+id/toolbar"
        android:layout_width="match_parent"
        android:layout_height="?attr/actionBarSize"
        android:background="@drawable/btn_red_gradient"
        android:title="@{controller.title}"
        app:showBackButton="@{controller.previous != null}"
        app:itemClickListener="@{itemClickListener}"
        app:navigationClickListener="@{(NavigationClickListener)controller}"
        app:menu="@{menu}"
        android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar" />

</layout>

and I am including this in other layouts like this

 <?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools">

    <data>

        <variable
            name="controller"
            type="com.bonnti.screens.combthru.combthruitem.ItemCombthruController" />


        <import type="com.bonnti.R" />

        <import type="com.bonnti.misc.utils.TextUtils" />
    </data>

    <RelativeLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent">


        <RelativeLayout
            android:id="@+id/toolbar_item_combthru"
            android:layout_width="match_parent"
            android:layout_height="wrap_content">

            <include
                layout="@layout/toolbar"
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                app:controller="@{controller}" />

            <LinearLayout
                android:id="@+id/linearLayout2"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_alignParentRight="true"
                android:layout_centerVertical="true"
                android:layout_marginTop="4dp"
                android:layout_marginRight="@dimen/size_2dp"
                android:clickable="true"
                android:onClick='@{controller::onThreeDotsClick}'
                android:padding="@dimen/size_10dp"
                android:visibility='@{controller.isThreeDotsVisible}'>

                <ImageView
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_marginRight="6dp"
                    android:src="@drawable/ic_point_first_white" />

                <ImageView
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_marginRight="6dp"
                    android:src="@drawable/ic_point"
                    android:tint="@color/white" />

                <ImageView
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_marginRight="6dp"
                    android:src="@drawable/ic_point"
                    android:tint="@color/white" />

            </LinearLayout>
        </RelativeLayout>


        <include
            android:id="@+id/list"
            layout="@layout/list"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_below="@+id/toolbar_item_combthru"
            android:layout_marginBottom="@dimen/size_40dp"
            app:adapter="@{controller.adapter}"
            app:loadMoreListener="@{controller}" />

        <RelativeLayout
            android:id="@+id/input"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_alignParentBottom="true"
            android:background="@color/white"
            android:padding="@dimen/size_10dp"
            android:visibility='@{controller.isCommentMode}'>

            <ImageView
                android:id="@+id/ic_im"
                android:layout_width="20dp"
                android:layout_height="20dp"
                android:scaleType="centerInside"
                app:srcCompat="@drawable/ic_combthru_comments" />

            <EditText
                android:id="@+id/et_text"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:layout_centerVertical="true"
                android:layout_marginLeft="@dimen/size_10dp"
                android:layout_marginRight="@dimen/size_10dp"
                android:layout_toStartOf="@+id/ic_sent"
                android:layout_toEndOf="@+id/ic_im"
                android:background="@null"
                android:hint="@string/comment"
                android:textColor="@color/textColor"
                android:textSize="@dimen/size_14sp" />

            <ImageButton
                android:id="@+id/ic_sent"
                android:layout_width="20dp"
                android:layout_height="20dp"
                android:layout_alignParentRight="true"
                android:background="@null"
                android:onClick='@{controller::sentComment}'
                android:scaleType="centerInside"
                app:srcCompat="@drawable/ic_comb_sendcomment" />
        </RelativeLayout>


    </RelativeLayout>
</layout>



public abstract class Controller<B extends ViewDataBinding> extends SerializableController<B> {
    @Override Strategy<B> createStrategy() {
        return new FragmentStrategy<>(this);
    }
}

public abstract class BonntiController<B extends ViewDataBinding> extends Controller<B> implements NavigationClickListener {
    private static final String TAG = BonntiController.class.getSimpleName();


    public void onMediaSelected(String uri) {
        // stub
        Log.w(TAG, "onMediaSelected: activity result ignored");
    }

    protected void onBroadcastReceived(Intent intent){
        // stub
        Log.w(TAG, "onBroadcastReceived: activity result ignored");
    }


    //back arrow click
    @Override public void onNavigationClick() {
        back();
    }
}


public class ItemCombthruController extends BonntiController<LayoutItemCombthruBinding> implements RemoveCommentListener,
        LoadMoreListener {

    public final Combthru combthru;
    public BaseAdapter<BaseVM> adapter = new BaseAdapter<>(new ArrayList<>());
    public ObservableBoolean isCommentMode = new ObservableBoolean();

    public ItemCombthruController(Combthru combthru) {
        Log.d("BBB", "YES!!!");
        this.combthru = combthru;
        adapter.add(new ItemCombthruTopVM(combthru, this));
        if (combthru.comments != null && combthru.comments.size() != 0) {
            for (Combthru.Comment comment : combthru.comments) {
                adapter.add(new CombthruCommentVM(this, comment, this));
            }
        }
        isCommentMode.set(true);
    }
}

My problem is that it gives me below error. I have tried everything from stackoverflow (clean project, invaidate cache/restart, rebuild project, include kotlin etc)and issue did not solve. When I press app:controller="@{controller}" it says that "cannot find declararion to go". Any help will be appreciated. Thanks in advance.

****/ data binding error ****msg:Cannot find the setter for attribute 'app:controller' with parameter type com.bonnti.screens.combthru.combthruitem.ItemCombthruController on com.bonnti.databinding.ToolbarBinding. file:D:\\bonnti-android-gitlab\\app\\src\\main\\res\\layout\\layout_item_combthru.xml

Answer 1

You also need to change the included layout as a data binding layout. ie you need to wrap the included layout with the layout tag same as in your parent layout.

Answer 2

Use bind namespace to bind variables . Then your root layout should look like

<layout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:bind="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools">

and Included One Should be

<include
   layout="@layout/toolbar"
   android:layout_width="match_parent"
   android:layout_height="wrap_content"
   bind:controller="@{controller}" />

Ok so with Updated question what i found the type of controller variable is different in both layouts which should be same .

So if you are using variable of type com.cvvm.Controller then it should be

<variable
        name="controller"
        type="com.cvvm.Controller" />

in both the layouts. and your main layout should be as

<layout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:bind="http://schemas.android.com/apk/res-auto">
<data>
    <variable name="controller" type="com.cvvm.Controller" />
</data>
..............
<include
        layout="@layout/toolbar"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        bind:controller="@{controller}" />
......................