服务意图 getaction 和 getextra 返回 null

Question

I have a really bad problem I have one notification service wich its work fine when i test it works just fine i turn off/on 10 times to see if service failed or return null but it works fine i also close application many time to see if its return null but its work fine. but sometimes when I'm daily using my phone application show force close such as when I'm using other apps , crash system of firebase say getaction or intent is null. plz help me whats im doing wrong

crash system

this is my service code:

 @Override
public int onStartCommand(Intent intent, int flags, int startId) {
    sp = getSharedPreferences("accdata", Context.MODE_PRIVATE);
    namesaveget = sp.getString("nameacc","No Account");
    int getwhattodo = intent.getIntExtra("service_call",0);
    if (intent == null || intent.getAction() == null || getwhattodo == 0) {
        Log.e("receiver","service faild");
        Crashlytics.log("service faild to call");
        if (getwhattodo == 0) {
            stopSelf();
        }

    }
    if (intent != null && getwhattodo == 2) {
        Log.e("receiver","call done");
        createNotificationChannel();
        showMainNotification();
        showSubNotifications();
        Crashlytics.log("service call noti");
    }


    return START_STICKY;

}

this is my receiver that call my service:

 @Override
public void onReceive(Context context, Intent intent) {
    Log.e("receiver","work");

    if (isNetworkConnected(context) == true) {


            Log.e("receiver","wifi on");
            Intent i = new Intent(context,ServiceNotifications.class);
            i.putExtra("service_call",2);
            context.startService(i);




    } else {
        Log.e("receiver","wifi off");
    }



}

public static boolean isNetworkConnected(Context c) {
    ConnectivityManager connectivityManager =
            (ConnectivityManager) c.getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo activeNetworkInfo = connectivityManager.getActiveNetworkInfo();
    return activeNetworkInfo != null && activeNetworkInfo.isConnected();
}

i also tired: use start_stick service it wont work. im trying use intent extra int instead of getaction but it didn't work either.

so any solution for this whats I'm doing wrong.

Answer 1

if you are not sure if intent is null or not but still you are making a call just move int getwhattodo = intent.getIntExtra("service_call",0); call inside your null check

int getwhattodo = intent.getIntExtra("service_call",0);
    if (intent == null || intent.getAction() == null || getwhattodo == 0) {
        Log.e("receiver","service faild");
        Crashlytics.log("service faild to call");
        if (getwhattodo == 0) {
            stopSelf();
        }

    }