如何从结构数组中获取所有元素，并将它们添加到 c 中的字符串中？

Question

char str[vector_total(&final_clause)];
    for(int i = 0; i<vector_total(&final_clause); i++)
    {
          printf("%s  ", (char*) vector_get(&final_clause,i)); // outputs b  a  -c  a  a  -c  -c
          strcpy(str, (char*) vector_get(&final_clause,i));
    } 
    printf("%s", str); //only prints -c (last )
    remove_repeatation(str); // removes repeats. Expected: b a-c

Evidently its replacing 'str' everyloop. So what is the best way to fix this? Not sure if this is a easy question but I just haven't been able to crack it using different approaches.

Answer 1

char str[vector_total(&final_clause)]; too small.

size_t len = vector_total(&final_clause);
char str[len*2 + 1]; // might be enough

//only prints -c (last )

Code copies vector_get() into the same location so this is expected.

Perhaps use strcat() and str[0] = 0; for the first strcat(str, .. to work.

Answer 2

You need to use strcat instead of strcpy . strcpy replace the content of str by the result of vector_get() when strcat concatenate str and vector_get() .

This should fix your problem:

char str[vector_total(&final_clause)];
char *result = NULL;
str[vector_total(&final_clause)] = '\0;
    for(int i = 0; i<vector_total(&final_clause); i++)
    {
          printf("%s  ", (char*) vector_get(&final_clause,i)); // outputs b  a  -c  a  a  -c  -c
          result = realloc(result, (sizeof(char) * strlen(vector_get(&final_clause,i));
          result = strcat(result, (char*) vector_get(&final_clause,i));
    } 
    printf("%s", str);
    remove_repeatation(str);