c# 重构与 linq 查询

Question

I am trying to improve my linq syntax coding and i was wondering if anyone could show me a better way of writing this code below.Question is taken from leetcode https://leetcode.com/problems/kids-with-the-greatest-number-of-candies/ . Thanks

        public static IList<bool> KidsWithCandies(int[] candles, int extraCandies)
        {
           var kidCandle = candles.Select(x => x+ extraCandies);
           var con = new List<bool>();
            foreach(var kid in kidCandle)
            {
                if (kid >= candles.Max())
                    con.Add(true);
                else
                    con.Add(false);
            }

           return con;
        }

https://leetcode.com/problems/kids-with-the-greatest-number-of-candies/

Answer 1

Linq also does looping but just a syntacitc sugar, but we can write a Select for the foreach. So the code:

var con = new List<bool>();
foreach(var kid in kidCandle)
{
    if (kid >= candles.Max())
        con.Add(true);
    else
        con.Add(false);
}

can be replaced with:

public static IList<bool> KidsWithCandies(int[] candles, int extraCandies)
{
   var kidCandle = candles.Select(x => x+ extraCandies);
   var maxCandles = candles.Max();
   var con = kidCandle.Select(kid => (kid >= maxCandles)).ToList();
   return con;
}

even the whole method could be written like:

public static IList<bool> KidsWithCandies(int[] candles, int extraCandies)
{
    var maxCandles = candles.Max();
    return candles.Select(x => x+ extraCandies)
                 .Select(kid => (kid >= maxCandles)).ToList();
}

Now more simpler:

public static IList<bool> KidsWithCandies(int[] candles, int extraCandies)
{
   var maxCandles = candles.Max();
   var con = candles.Select(kid => (kid + extraCandies >= maxCandles)).ToList();
   return con;
}

we can even avoid var :

 public static IList<bool> KidsWithCandies(int[] candles, int extraCandies)
 {
     var maxCandles = candles.Max();     
     return candles.Select(kid => (kid + extraCandies >= maxCandles)).ToList();
 }