Servlet 不更新数据库中的值

Question

I'm trying to create a basic password reset system. I'm creating an unique token for each user, storing in database and retrieving that token value in url like: http://localhost:8080/login/reset-password.jsp?token=0d1eaa1a-869c-4f40-8437-a3cdaeddf497

The problem here is that I'm trying to update the password in the database but the value isn't updated. It displays that the password is changed, but nothing happens in database. Please help.

Here's my servlet:

protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {

        String password = request.getParameter("password");
        String token = request.getParameter("token");



                ForgotPasswordHandler.UpdatePassword(password, token);

                String message = "Password changed!";
                request.setAttribute("message", message);
                request.getRequestDispatcher("reset-password.jsp?token=" + token).forward(request, response);   



    } 

Here's my method in class ForgotPasswordHandler.java:

public static void UpdatePassword(String password, String token) {

            try
              {

              if (con == null){
                 System.out.println("Failed connection");

              }else{

                PreparedStatement ps = con.prepareStatement(
                  "UPDATE user SET password = ? WHERE reset_token = ?");

                ps.setString(1,password);
                ps.setString(2,token);

                ps.executeUpdate();

                ps.close();


              }}
            catch (Exception e) {
                 e.printStackTrace(System.out);    
              }

            }

Answer 1

Your connection may have autoCommit turned off. If that is the problem you can fix it with code like this:

   if (!con.getAutoCommit()) {
      con.commit();
   }

One other thing to note is that if the call to ps.executeUpdate() fails, the prepared statement will not be cleaned up. To avoid that problem move the close to the finally block. Here is what the full code would look like:

PreparedStatement ps = null;
try
{
    if (con == null){
        System.out.println("Failed connection");
    } else {
        ps = con.prepareStatement(
            "UPDATE user SET password = ? WHERE reset_token = ?");

        ps.setString(1,password);
        ps.setString(2,token);

        ps.executeUpdate();   

       if (!con.getAutoCommit()) {
          con.commit();
       }
    }
}
catch (Exception e) {
        e.printStackTrace(System.out);    
} 
finally {
    if (ps != null) {
        ps.close();
    }
}