C# bool 并以简洁的方式关闭 function？

Question

I got following code.

public class MpChange : CusEffect
{
    bool AlreadyDo = false;
    bool AlreadyStop = false;

    public override void CondDel(object sender, CondEventArgs e)
    {
        if (e.CondMet && !AlreadyDo)
        {
            DoEffect();
            AlreadyDo = true;
            AlreadyStop = false;
        }
        else if (!e.CondMet && !AlreadyStop)
        {
            StopEffect();
            AlreadyStop = true;
            AlreadyDo = false;
        } 
    }

    public override void DoEffect()
    {
        Debug.Log(WhoEffect.name + "'s Mp changed +5");
    }
    
    public override void StopEffect()
    {
        Debug.Log(WhoEffect.name + "'s Mp changed -5");
    }
}

This is called when character's hp is full, (then DoEffect()), and if not full, then StopEffect().

When character's hp is changed, event published and this MpChange class is subscribe it.

In this case, can this code be neat?

I hate to using this 2 boolean variables (AlreadyDo, AlreadyStop), being confused.

Answer 1

One boolean will do:

    bool State = false;
    public override void CondDel(object sender, CondEventArgs e)
    {
        if (e.CondMet == State) return;  // nothing to do, state's the current one
        State = !State;  // flip the flag
        if (State) {  // do or undo a thing
            DoEffect();
        } else {
            StopEffect();
        }
    }

Answer 2

So instead using boolean, I should use enum.

I set,

public enum ConditionState
{
None, Complete, Incomplete,
}

and change condition code part based on enum state and prevent duplicate calling,

public abstract class CusCondition
{
public bool Earned;      
public int SealValueCond;
public ConditionState conditionMet;
private ConditionState prevCond = ConditionState.None;
[HideInInspector]
public Character WhoCondition;       
public virtual void ConditionEvent(object sender, MyEventArgs myEventArgs)
{
    SealManager.Instance.PublishEvent(this, new CondEventArgs(conditionMet));
}
public virtual void ConditionEventState(object sender, MyEventArgs myEventArgs)
{       // execute only once state changes 
    if (conditionMet == prevCond) return;
    prevCond = conditionMet;
    SealManager.Instance.PublishEvent(this, new CondEventArgs(conditionMet));
}
}

and then at effect part, this is enough.

public override void CondDel(object sender, CondEventArgs e)
{ 
    if (e.CondMet == ConditionState.Complete)
        DoEffect();
    else if(e.CondMet == ConditionState.Incomplete)
        StopEffect();
}