SQL Server 存储过程将错误的值插入位列

Question

I have a SQL Server stored procedure as follows

ALTER PROCEDURE [dbo].[AccessHistoryUpdate] 
    (@empPk int,
     @doorPk int)
AS
BEGIN
    SELECT ISNULL(@empPk, 0);
    SELECT ISNULL(@doorPk, 0);

    DECLARE @employeeRanking int;
    DECLARE @doorRanking int;

    SELECT
        SUM(e.SecurityDeviceId) AS emp
    FROM
        EmployeeSecurityDevice e
    WHERE
        e.EmployeeId = @empPk;

    SELECT
        SUM(d.SecurityDecivceId) AS door
    FROM
        DoorSecurityDevice d
    WHERE
        d.DoorId = @doorPk;
        
    IF (@employeeRanking >= @doorRanking)
    BEGIN
        INSERT INTO AccessHistory (AttemptDate, DoorId, EmployeeId, Result)
        VALUES(GETDATE(), @doorPk, @empPk, 1);
    END
    ELSE
    BEGIN
        INSERT INTO AccessHistory (AttemptDate, DoorId, EmployeeId, Result)
        VALUES (GETDATE(), @doorPk, @empPk, 0);
    END
END

The result column is a bit column and I wrote if employeeRanking is greater than door ranking, it should return 1. For some reason it's returning 0 (behaving the reverse of what I would have expected)

Can someone point me where I'm going wrong?

Thanks

Answer 1

You are missing the assignment of the variables, this should do:

    select 
        @employeeRanking = sum (e.SecurityDeviceId)
    from 
        EmployeeSecurityDevice e
    where 
        e.EmployeeId = @empPk;

    select 
        @doorRanking = sum(d.SecurityDecivceId)
    from 
        DoorSecurityDevice d
    where 
        d.DoorId = @doorPk;