如何避免在 php 中的 URL 中重复路径？

Question

I have an URL path like

http://localhost:8080/laravel/api/data/create/

Where /laravel/api is the path from the config file

and /data/create/ is the path which I used in traits .

The problem is everytime when I run the function named connection() repeatedly,

In Tinker, If I do

$data = new Sample;
$data->connection();
http://localhost:8080/laravel/api/data/create/
$data->connection();
http://localhost:8080/laravel/api/data/create/data/create/
$data->connection();
http://localhost:8080/laravel/api/data/create/data/create/data/create/

The path /data/create/ is repeated every time when I perform connection().

It should not be like that, only once the path should be appended, if we perform connection(), like the below.

$data->connection();
http://localhost:8080/laravel/api/data/create/

I am using a method chaining for appending path .

protected $resource[]; //is declared already in the code
protected $url[];
public function addPath()
{
        $old_uri = explode('/', $this->resource['path']);
        $add_uri = explode('/', $this->path);
        $new_uri = array_merge($old_uri, $add_uri);
        $this->resource['path'] = '/'.implode('/', array_filter($new_uri));
        return $this;
    
   }

public function connection()
{
   $this->addPath()->unparse_url();
   return $url;
}

private function unparse_url()
    {
        $scheme = isset($this->resource['scheme']) ? $this->resource['scheme'].'://' : '';
        $host = isset($this->resource['host']) ? $this->resource['host'] : '';
        $port = isset($this->resource['port']) ? ':'.$this->resource['port'] : '';
        $user = isset($this->resource['user']) ? $this->resource['user'] : '';
        $pass = isset($this->resource['pass']) ? ':'.$this->resource['pass'] : '';
        $pass = ($user || $pass) ? "$pass@" : '';
        $path = isset($this->resource['path']) ? $this->resource['path'] : '';
        $query = isset($this->resource['query']) ? '?'.$this->resource['query'] : '';
        $fragment = isset($this->resource['fragment']) ? '#'.$this->resource['fragment'] : '';

        $this->url = "$scheme$user$pass$host$port$path$query$fragment";

        return $this;
    }

Could someone please help to fix the issue? Thanks.

Answer 1

If we disregard from your undefined variables, the issue is that your code appends the path every time you call the connection() -method since it calls the addPath() -method.

If you only want it to append it once, there are some alternatives.

Alternative 1

If you always want the path to be added, you can simple call the addPath() -method from the constructor instead.

public function __construct()
{
    $this->addPath()->unparse_url();
}

and just have the connection() -method like this:

public function connection()
{
    return $this->url;
}

This would work well as long as you don't need to use the original values of $this->url and $this->resource['path'] for anything since they will be changed when the class is instantiated.

Alternative 2

You can set class property as a flag, saying if the path already been added or not. Then you simply check that flag in your addPath() -method.

// Default value is false, since we haven't added it yet
protected $pathAdded = false;

public function addPath()
{
    if ($this->pathAdded === false) {
        // It's still false so it hasn't been added yet
        
        $old_uri = explode('/', $this->resource['path']);
        $add_uri = explode('/', $this->path);
        $new_uri = array_merge($old_uri, $add_uri);
        $this->resource['path'] = '/'.implode('/', array_filter($new_uri));

        // Set the flag to true so we know it's already been done
        $this->pathAdded = true;
    }

    return $this;
}

This way, it will only append the path on the first call to that method.