通过 id nodejs, javascript 删除数组中的 object

Question

I am having issues deleting an object by id in an array(database).

route.delete('/:id', (req, res) =>{
let match = false
for(let i=0; i< database.posts.length; i++){
if(id == database.posts[i].id){
match = true;
database.posts.splice(id, 1)
}
return res.json({status: 'Success', message : 'Entry deleted'}
}
}
if(!match){
return res.json('Cannot delete entry')
}
} )

`````

In my database I have a list of object with its unique id (1- 10), meaning the index is (0-9). The code work fine when I start deleting by id fromthe end of the array. But when I delete from the middle of the array,it delete another posts instead. For example, if I delete an object with id 3 (index 2), afterward trying deleting an object with id 4, the code deletes object with id 5 instead because there's been a change in the index.

Please can I better improve this code to work appropriate?

Answer 1

route.delete('/:id', (req, res) => {
    let match = database.posts.findIndex(post => post.id === req.params.id)
    if (match < 0) // not found returns -1
        return res.status(404).json({ status: 'error', message: 'Entry ID not found' })
    
    database.posts.splice(match, 1)
    return res.json({ status: 'success', message: 'Entry deleted' })
})